It would be nice if the message that is sent to watchdog when linkchecker saves a new node revision was ALSO sent to the node revision table, so an admin can easily tell why a new revision was saved. I'll submit a patch later today.

CommentFileSizeAuthor
#4 linkchecker_revision_log.patch1.4 KBbradweikel
#2 linkchecker_revision_log.patch901 bytesbradweikel

Comments

hass’s picture

hass commented

Good idea. We need to get this in - very soon... next release is very close.

bradweikel’s picture

bradweikel commented
StatusFileSize
new linkchecker_revision_log.patch901 bytes

Here's a patch for the DRUPAL-6--2 branch.

Not sure whether $node->log should be set if a new revision isn't being created. Don't know that it makes much difference either way.

hass’s picture

hass commented
Title: Feature Request: Add a message to $node->log when saving a new revision » Add a message to $node->log when saving a new revision
Status: Active » Needs work

It's new to me that html code can be added to log message. As I know - it need to be plain text?!?

Please provide unified patches.

bradweikel’s picture

bradweikel commented
Status: Needs work » Needs review
StatusFileSize
new linkchecker_revision_log.patch1.4 KB

Unified patch attached. I'm always forgetting -U.

The HTML gets filtered to plain text when it's displayed. This way the string gets reused for the watchdog message, which I think is a little cleaner, but you could also create two different strings. Either way is fine - the pro's and con's are marginal either way.

bradweikel’s picture

bradweikel commented

Or you could just wrap a check_plain() around the assignment. Let me know if you want me to re-roll it that way.

hass’s picture

hass commented
Status: Needs review » Fixed

Committed slightly changed version to all branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.