Posted by Sutharsan on November 14, 2009 at 4:32pm
Jump to:
| Project: | Node As Block |
| Version: | 6.x-1.x-dev |
| Component: | Miscellaneous |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Issue Summary
The block title is currently hardcoded :( as a link. In the way I use the module I do not want a link to the node at all. The attached patch adds a theme function to allow override.
| Attachment | Size |
|---|---|
| nodeasblock.theme_title.patch | 1.22 KB |
Comments
#1
Hi Sutharsan
Thanks for your patch. I had the same issue. It's solved now.
@maintainers: Could this patch be included in the standard module?
Thanks
Tobias
#2
+1
#3
Hey Sutharsan, I wanted to RTBC your patch but could you review it? I'm trying to patch the current dev but it doesn't really do anything on a brand new drupal. I'm guessing things have changed in the code. If it's not too hard it would probably be best to make it a setting: Do you want the block title to be linked to the node? I would be fine without the setting since I only want an unlinked title. If it's not a setting it could also be done in the template file, which is currently not possible. I'll be happy to test a revised patch as soon as it's there.
#4
From a user's point of view is does not change anything indeed. The patch provides the possibility for theme override of the block title. I am not a great fan of loads of features. Better choose sensible defaults and give an option to override in the theming layer (in code). But even if an option would be added it is the Drupal way to provide theme override options.
#5
This change looks good to me, I agree with you Sutharsan about not requiring a UI configuration for every single thing. Linking the title is a sensible default, but being able to undo that easily in the theme layer is a good option.