I get this warning by following the steps below:

Warning: require_once(/Users/alex/Sites/d7/head/modules/taxonomy/taxonomy.feeds.inc): failed to open stream: No such file or directory in menu_execute_active_handler() (line 460 of /Users/alex/Sites/d7/head/includes/menu.inc).

Steps to reproduce:

  • Clean d7 install
  • Create a new story with a tag
  • browse to /taxonomy/term/1/edit
CommentFileSizeAuthor
#11 632888_5_combined.patch2.12 KBbleen
#8 632888_4.patch839 bytesbleen
#8 632888_4test.patch1.44 KBbleen
#6 632888_3.patch2.18 KBbleen
#3 632888.patch839 bytesbleen
#1 632888.patch1.11 KBbleen

Comments

bleen’s picture

bleen commented
Status: Active » Needs review
StatusFileSize
new 632888.patch1.11 KB

I assume that taxonomy.feeds.inc is needed to create RSS feeds but the file is missing from HEAD. Assuming that the file is no longer needed (which I doubt), this patch fixes the error.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Priority: Critical » Normal
Status: Needs review » Needs work
Issue tags: +Quick fix

I was able to reproduce this bug, although the problem occurs on /taxonomy/term/1/feed, not on /taxonomy/term/1/edit...

While the patch in #1 fixes the issue, it goes a bit too far and removes the feed menu item entirely. It looks like taxonomy_term_feed was moved to taxonomy.pages.inc, so it's enough to just change the file name.

@bleen18: can you re-roll the patch with just that change?

bleen’s picture

bleen commented
Status: Needs work » Needs review
StatusFileSize
new 632888.patch839 bytes

re-rolled according to mr.baileys suggestion.

catch’s picture

catch
he/him
Primary language English
commented

Patch is good. Ideally we'd also add to one of the tests in taxonomy.test to do a drupalGet("taxonomy/term/$tid/feed"); - which should fail without the patch applied.

bleen’s picture

bleen commented

@catch ... agreed. This may be a good opportunity for me to figure out how to actually create tests... I'll play. In the mean time can we mark RTBC?

bleen’s picture

bleen commented
StatusFileSize
new 632888_3.patch2.18 KB

re-rolled patch to include a simpletest ... it's the first test I've added and it seemed ... well... too simple so please make sure I did it correctly when reviewing. Thanks!

catch’s picture

catch
he/him
Primary language English
commented

That looks completely fine. Can you do two things?

1. Post a patch with just the test so we can watch it fail tests. This is optional but verifies the test actually gets affected by the patch.

2. Post that same patch, but without extra whitespace on the empty lines.

Then this is rtbc.

bleen’s picture

bleen commented
StatusFileSize
new 632888_4test.patch1.44 KB
new 632888_4.patch839 bytes

Slowly but surely I'm getting all the nuances down

Status: Needs review » Needs work

The last submitted patch failed testing.

catch’s picture

catch
he/him
Primary language English
commented

Awesome. Now we just need the combined patch from #6 without the trailing whitespace so it can be committed in one pass.

bleen’s picture

bleen commented
Status: Needs work » Needs review
StatusFileSize
new 632888_5_combined.patch2.12 KB

cool beans

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.