Starting from scratch with the minimal profile chosen during installation, I try to enable the toolbar module and get this error message:

Fatal error: Call to undefined function menu_save() in /home/didascalie/www/modules/toolbar/toolbar.install on line 22

As one could guess, enabling the toolbar and menu modules at the same time works fine. So there must a dependency issue here.

Comments

davidtrainer’s picture

StatusFileSize
new570 bytes

Confirmed; even after install time, disabling menu while toolbar remains enabled causes an error.

davidtrainer’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch failed testing.

davidtrainer’s picture

StatusFileSize
new570 bytes
davidtrainer’s picture

StatusFileSize
new570 bytes
davidtrainer’s picture

Status: Needs work » Needs review
moshe weitzman’s picture

Status: Needs review » Active

or move menu_save (and whatever it calls) to menu.inc. i thought we discussed that a while ago. recall that tha_sun was in that issue but thats not surprising :)

jody lynn’s picture

Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new720 bytes

This was already fixed in #510368: Should toolbar depend on menu module? (for menu_custom table) but it looks like it was accidentally removed: http://drupalcode.org/viewvc/drupal/drupal/modules/toolbar/toolbar.info?...

This happened with a commit from here: http://drupal.org/node/511286#comment-2160948

Patch attached undoes that commit to toolbar.info

gpk’s picture

Actually it was the patch here that removed the dependency #511286-182: D7UX: Implement customizable shortcuts.

Also does the .install file need to be listed in the .info file? It seems to get loaded anyway, hence this error.

David_Rothstein’s picture

Status: Needs review » Closed (duplicate)

See #637702: Get rid of Administration Shortcuts menu - the toolbar.install file isn't supposed to be there at all.

(We actually deleted that file as part of the patch that was committed at http://drupal.org/node/511286#comment-2160402, but I guess it went unnoticed due to the large size of the patch, and no one ran "cvs remove"...?)