While i was writing the patch for Exposed items per page, I have discovered that pre_render is never called for exposed forms plugins.
Also post_execute() is not necessary for a plugin, so I deleted it.
There is, however, a performance issue here. Since handlers are not loaded again when pre_execute is called into views_plugins_display, I had to add an init_handlers() call to determine if current view is using exposed forms. I don't know if it is really important to use a cache method or something similar.
| Comment | File | Size | Author |
|---|---|---|---|
| exposed-forms-pre_execute-nevel-called.patch | 1.29 KB | dagmar |
Comments
Comment #1
dagmarSorry it is pre_excute instead of pre_render.
Comment #2
merlinofchaos commentedCommitted to 6.x-3.x branch.
Comment #3
dawehnerIts waiting for #633482: pre_execute is never called on exposed forms plugins....
Comment #4
dagmardereine: it is the same issue...
Comment #5
dawehnerAh sry. I thougth postponed is for issues, which waits for other issues.
Comment #6
merlinofchaos commenteddereine: You marked this issue as being postponed, waiting for itself. =)
I committed this patch to the 6.x-3.x branch and marked it as needing to be ported to the 7.x-3.x branch. Though it may be waiting for the exposed forms as plugins for 7.x, it could just as easily be combined into that patch.
Comment #7
dawehnerThe patch applies clean on d7.
Comment #8
dagmarI think this can be included in d7 without problems.
Comment #9
dawehnerFixed