While i was writing the patch for Exposed items per page, I have discovered that pre_render is never called for exposed forms plugins.

Also post_execute() is not necessary for a plugin, so I deleted it.

There is, however, a performance issue here. Since handlers are not loaded again when pre_execute is called into views_plugins_display, I had to add an init_handlers() call to determine if current view is using exposed forms. I don't know if it is really important to use a cache method or something similar.

Comments

dagmar’s picture

Title: pre_render is never called on exposed forms plugins » pre_execute is never called on exposed forms plugins

Sorry it is pre_excute instead of pre_render.

merlinofchaos’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Needs review » Patch (to be ported)

Committed to 6.x-3.x branch.

dawehner’s picture

Status: Patch (to be ported) » Postponed
dagmar’s picture

Status: Postponed » Patch (to be ported)

dereine: it is the same issue...

dawehner’s picture

Ah sry. I thougth postponed is for issues, which waits for other issues.

merlinofchaos’s picture

dereine: You marked this issue as being postponed, waiting for itself. =)

I committed this patch to the 6.x-3.x branch and marked it as needing to be ported to the 7.x-3.x branch. Though it may be waiting for the exposed forms as plugins for 7.x, it could just as easily be combined into that patch.

dawehner’s picture

Status: Patch (to be ported) » Needs review

The patch applies clean on d7.

dagmar’s picture

Status: Needs review » Reviewed & tested by the community

I think this can be included in d7 without problems.

dawehner’s picture

Status: Reviewed & tested by the community » Fixed

Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.