Closed (fixed)
Project:
Quick Tabs
Version:
6.x-2.0-rc4
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Nov 2009 at 02:50 UTC
Updated:
22 May 2010 at 22:20 UTC
I have a few quicktabs blocks set up on my site, none are using ajax.
On my pages, the header has each tab escaped as a long string in the Drupal.settings variable.
But there are also 2 div tags with the full tabs in the body of the code, so I would think that the code would just show/hide these divs, and wouldn't need the tab as a variable.
Is it possible to get rid of this long settings variable in the header of the page?
thanks.
Comments
Comment #1
loze commentedComment #2
pasquallethis is used when you load the tab content with ajax.. maybe we can remove it when using non-ajax quicktabs..
Comment #3
loze commentedaround line 193 in quicktabs.module, I have replaced
drupal_add_js(array('quicktabs' => array('qt_'. $quicktabs['qtid'] => $quicktabs)), 'setting');with
and the view code is not included in drupal.settings.
thanks.
Comment #4
pasquallehttp://drupal.org/cvs?commit=292432
this change should remove the unnecessary values from Drupal.settings
Comment #6
pasquallethis patch needs php 5.2. for array_fill_keys(). That should not be a requirement for QT 6.x
Comment #7
pasquallesimilar issue fixed in Drupal core:
http://drupal.org/cvs?commit=337322
#732096: Fatal error: Call to undefined function: array_intersect_key() in url/modules/update/update.compare.inc on line 695
Comment #8
pasqualle#703620: 6.x-2.0-rc4 error array_fill_keys()