node_access_acquire_grants doc header needs some cleanup

Agreed, that function doc definitely needs a bit of cleanup. It also says "This function will call module invoke to...", which doesn't even mention which hook is invoked. Sheesh!

And it should be fixed in D7 first, then ported back to D6.

Here's a doc cleanup patch, for this function and the next one below it in the file. Should be ported to D6 if accepted.

Committed to CVS HEAD.

Needs D6 port.

In the D6 version of http://api.drupal.org/api/function/node_access_acquire_grants, there is actually no call to hook_node_access_records_alter() (i.e. no drupal_alter('node_access_records'). So this patch is not correct for D6.

Ah yes, only D7 lets modules alter the grants, thanks.

The text looks right now. One minor line wrap issue:

+ * This function is called when a node is saved, and can also be called by
+ * modules if something other than a node_save causes node access permissions
+ * to change. It collects all node access grants for the node from
+ * hook_node_access_records() implementations and saves the
+ * collected grants to the database.

I think collected should be on the previous line?

I agree; this should do it.

Sorry, missed this in the last readthrough:

All functions should have () after them, such as node_save(). This makes them turn into links on api.drupal.org.

I added an underscore by accident; your patch did not do that and I assume wasn't meant to reference a function:
* modules if something other than a node save causes node access permissions

Removes the underscore:

Thanks! That looks fine.

Oops, spoke too soon. The patch needs to be rerolled from the Drupal root.

grrr, wrong setting in Eclipse, I think. Better?

double grrr. IGNORE #14, wrong patch. Correct one:

Looks fine now, thanks!

Thanks, committed.