Closed (fixed)
Project:
AddToAny Share Buttons
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Nov 2009 at 16:14 UTC
Updated:
26 Mar 2011 at 09:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
toomanypets commentedThere are several issues here.
First, it is not possible to change the displayed value of "Button image HTML attributes" on /admin/settings/addtoany due to a typo. Lline 83 of addtoany.admin.inc reads:
$form['addtoany_button_settings']['addtoany_custom_image_attributes'] = array(
This should be:
$form['addtoany_button_settings']['addtoany_image_attributes'] = array(
Second, the alt tag was never intended (W3C) to provide tool tips on mouseover. I believe that alt provided tooltips on mouseover with older browsers, but it is certainly non-functional with the latest versions of FF and IE (tested FFwin 3.5.5 and IE8). You should use the title tag instead.
After making the correction to line 83, I set "Button image HTML attributes" to alt="Share/Save" title="Share/Save" and everything seems to be working properly.
Finally, you may wish to change the module's default value for this field, and the corresponding description, to prevent alt/title confusion in the future.
Comment #2
michael_lessard_micles.biz commentedI have version 1.7.2.4, which does not write addtoany_custom_image_attributes,
and still any change to "Button image HTML attributes" is not saved.
Comment #3
micropat commentedWill be fixed in the next release. Thanks for the reports!
Comment #4
micropat commentedComment #5
ao2 commentedHi, I am attaching a patch to fix the issue in 6.x-2.4, I didn't check if this is fixed in CVS already.
Regards,
Antonio
Comment #6
ao2 commentedThe fix above is alternative to the one in #380180: Field "Button image HTML attributes" not saved (admin page), so either this or the other should be marked as duplicate.
I personally prefer the version with the "_custom_" string in the variable, but you choose the one you like more.
Thanks,
Antonio
Comment #7
ao2 commentedPing.
Comment #9
ao2 commentedPing.
Comment #10
Anonymous (not verified) commentedThanks , i'll get this patch committed to the development branch later today,
Best,
Paul Booker
Appcoast
Comment #11
Anonymous (not verified) commentedComment #12
micropat commented