- the alt text (as defined in configuration: Button image HTML attributes) is not displayed on mouse-over
- any change to Button image HTML attributes is not saved when clicking on "Save configuration)

Comments

toomanypets’s picture

There are several issues here.

First, it is not possible to change the displayed value of "Button image HTML attributes" on /admin/settings/addtoany due to a typo. Lline 83 of addtoany.admin.inc reads:
$form['addtoany_button_settings']['addtoany_custom_image_attributes'] = array(

This should be:
$form['addtoany_button_settings']['addtoany_image_attributes'] = array(

Second, the alt tag was never intended (W3C) to provide tool tips on mouseover. I believe that alt provided tooltips on mouseover with older browsers, but it is certainly non-functional with the latest versions of FF and IE (tested FFwin 3.5.5 and IE8). You should use the title tag instead.

After making the correction to line 83, I set "Button image HTML attributes" to alt="Share/Save" title="Share/Save" and everything seems to be working properly.

Finally, you may wish to change the module's default value for this field, and the corresponding description, to prevent alt/title confusion in the future.

michael_lessard_micles.biz’s picture

I have version 1.7.2.4, which does not write addtoany_custom_image_attributes,
and still any change to "Button image HTML attributes" is not saved.

micropat’s picture

Assigned: Unassigned » micropat
Status: Active » Needs work

Will be fixed in the next release. Thanks for the reports!

micropat’s picture

Title: Alt text not displayed on button mouseover » Changes to Button image HTML attributes not saved
ao2’s picture

Status: Needs work » Needs review
StatusFileSize
new1.35 KB

Hi, I am attaching a patch to fix the issue in 6.x-2.4, I didn't check if this is fixed in CVS already.

Regards,
Antonio

ao2’s picture

The fix above is alternative to the one in #380180: Field "Button image HTML attributes" not saved (admin page), so either this or the other should be marked as duplicate.
I personally prefer the version with the "_custom_" string in the variable, but you choose the one you like more.

Thanks,
Antonio

ao2’s picture

Ping.

ao2’s picture

Ping.

Anonymous’s picture

Assigned: micropat »
Status: Needs review » Reviewed & tested by the community

Thanks , i'll get this patch committed to the development branch later today,

Best,
Paul Booker
Appcoast

Anonymous’s picture

Version: 6.x-2.4 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)
micropat’s picture

Assigned: » Unassigned
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.