tekante [tekante]

1.   if (!rmdir($js_path)) {
       drupal_set_message('Error removing third party wrappers js directory', 'error');
     }
     if (!rmdir($css_path)) {
       drupal_set_message('Error removing third party wrappers css directory', 'error');
     }
   

   Strings used in the user interface needs to be translated; this includes also the strings used as options for the form fields.

2. function third_party_wrappers_clean_directory($path, $age) {
     foreach (glob($path . '/*.*') as $file) {
       $atime = fileatime($file);
       if ($atime !== FALSE && $atime + $age < time()) {
         unlink($file);
       }
     }
   }
   

   The code should use file_scan_directory().

3.   $template = file_get_contents('http://' . $_SERVER['SERVER_NAME'] . $source_url);
   

   As the file is in the server running Drupal, why isn't the code using a local path, rather than using a URL, which could be not allowed from the PHP configuration?

4.         if ($action == 'meadtop')
           {
             $output = preg_replace('/<title>.*<\/title>/is', "<title><mtl \$STORY_TITLE></title>\n<meta name=\"description\" value=\"<mtl \$STORY_TEASER  escape_html=true blanks=\$MEAD_DEFAULT_DESCRIPTION>\">", $output);
           }  
   

   See the Drupal coding standards to understand how a module code should be written.

5.     '#title' => 'File Expiration',
       '#description' => 'Files which are saved will be deleted when their last access time + this value (in seconds) is less than the current time. 0 means do not delete files. There are 86400 seconds in a day',
   

   Strings used in user interface should have the first word in capital case, and the other words in lower case (with the exception of proper nouns, adjectives derived from proper nouns, and acronyms).

6. function third_party_wrappers_true() {
     return(TRUE);
   }
   

   Would not be easier to use directly the constant?

7.     'access arguments' => null,
   

   Not considering that the constant is not correctly written, if there is not the need to define access arguments, then that array index can be omitted. I am not even sure of the effect of setting those arguments explicitely to NULL.

8.   $items['third_party_wrappers/%'] = array(
       'title' => 'Third Party Wrappers',
       'description' => t('Handles generating a wrapper of the requested form'),
       'page callback' => 'third_party_wrappers_handler',
       'access callback' => 'third_party_wrappers_true',
       'access arguments' => null,
       'type' => MENU_CALLBACK,
     );
     $items['admin/build/third_party_wrappers'] = array(
       'title' => t('Third Party Wrappers Settings'),
       'description' => t('Administer settngs used when generating wrappers for your site'),
       'page callback' => 'drupal_get_form',
       'page arguments' => array('third_party_wrappers_admin'),
       'access arguments' => array('administer third_party_wrappers module'),
     );
   

   Menu callback titles, and descriptions should not be passed to t() because that is already done by Drupal core code.

I am still not convinced there is really a use case for this module, and if somebody could reach the same purpose using a different method / module.

The following lines should be better written, IMO.

  $source_url = preg_replace('/^[^\/]*\/[^\/]*/', '', $_GET['q']);
  $result = drupal_http_request('http://' . $_SERVER['SERVER_NAME'] . $source_url);
  $template = $result->data;

The module is requesting the page to view through drupal_http_request(), passing to the function the content of $_GET['q'], which would include the string third_party_wrappers; what is the result of preg_replace('/^[^\/]*\/[^\/]*/', '', "third_party_wrappers/user/12"), and what should the result be?

I think http://drupal.org/project/libraries does the same

The name could make you think so, but the purpose of the proposed module is to get a page from the local Drupal site, split it in two parts, and return the two parts as output of two different URLs.
So, http://staugustine.com/third_party_wrappers/top/zvents, and http://staugustine.com/third_party_wrappers/bottom/zvents are two parts of a single page (http://staugustine.com/zvents).

I am adding the review tags.

1. The code in hook_disable() should be moved in hook_cron(), if it is not already included, and hook_disable should be removed.
2. See the coding standards to understand how a module should be written; in particular see how the constants should be written, and how the code should be formatted.

Constants needs to be written in upper case characters (NULL, TRUE, FALSE, MODULE_CONSTANT, etc).