Adding CCK content_extra_fields support so you can move Skip Notifications fieldset around on manage fields page of the content type. Not sure if there is a way to check if any role has skip notifications ability?

CommentFileSizeAuthor
#8 content_extra_fields_4.patch665 bytesAnonymous (not verified)
#2 content_extra_fields_3.patch707 bytesAnonymous (not verified)
#1 content_extra_fields_2.patch708 bytesAnonymous (not verified)
content_extra_fields.patch700 bytesmshaver

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new content_extra_fields_2.patch708 bytes

Updated patch with proper function name ('notifications_content_content_extra_fields' instead of 'notifications_content_extra_fields') and added/removed extra spaces.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new content_extra_fields_3.patch707 bytes

Oops, stuffed that one up... Here's a better one.

jose reyero’s picture

jose reyero commented
Status: Needs review » Postponed (maintainer needs more info)

How does this work with the permission and with other modules adding fields here like notifications_team?

Anonymous’s picture

Anonymous (not verified) commented
Status: Postponed (maintainer needs more info) » Needs review

This simply allows you to change where the Notifications field appears in relation to other CCK fields on node-edit forms (basically gives you a GUI to set the weight).

AFAIK it doesn't, and shouldn't, affect permissions. If a user has permission to see and use Notifications, they'll see the field with or without this patch. As for other modules, if they provide a CCK field/fieldgroup, they'd also have to implement this hook (unless their field was a sub-field of this one...)

iancawthorne’s picture

iancawthorne commented

Just what I was looking for and seems to work fine. I'm also using notifications_team module and there appear to be no conflicts.

Would like to see this commited.

mrtoner’s picture

mrtoner commented
Status: Needs review » Reviewed & tested by the community

Patch works as advertised. Let me suggest these changes (no time to roll my own patch):

- Label should be "Notifications settings" -- it's more generic, not needing to be changed for additional settings in the future, and is in keeping with other items in the list

- Description should be "Content Notifications module form." -- it identifies the module that provides the form, just as the other items do

- The check for Notifications module is unnecessary, since the dependency on Notifications will prevent Notifications Content from being enabled without Notifications.

mrtoner’s picture

mrtoner commented
Status: Reviewed & tested by the community » Needs review

Sorry, I'm not the best one to say this is RTBC.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new content_extra_fields_4.patch665 bytes

Thanks for that, here's an updated patch.

ahjota’s picture

ahjota commented

Patch in #8 works on a test site running Drupal 6.16 and a production site running Drupal 6.15 (both sites run Notifications 6.x-2.1 ... do I need to change the Version?)

mrtoner’s picture

mrtoner commented
Status: Needs review » Reviewed & tested by the community

Nope, the request should go against dev. If Jose likes it, he'll commit it to the next version.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Version: 6.x-2.x-dev » 6.x-4.x-dev
Status: Reviewed & tested by the community » Fixed

Has been fixed in 6.x-4.x already a long time ago.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.