IMHO, the implementation of hook_send is a little reckless and should be renamed to something less likely to cause namespace collisions. Plenty of modules could potentially be naming their functions "MODULENAME_send()". An example is acquia_spi module:

http://acquia.com/node/1011148

That being said, I'm in favor of changing the acquia_spi module and not the Send module necessarily, because of all the other modules, contrib and custom, that could already be implementing hook_send and would break and have to be updated to reflect this api change. I just think it's worth mentioning that the use of common, short verbs as hooks has the potential to cause issues.

Comments

allie micka’s picture

Version: 6.x-1.x-dev » master
Status: Active » Fixed

Send has been all extra re-factored. hook_send no longer exists, so this is now moot!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.