On a site I am going to have lots of groups not using this feature and it annoyed me that the block was always visible. With this patch the function will return empty strings and the block will be hidden if there are no items to show - the test runs for empty($items) after the code has went through its loop. I added a comment also (assuming commenting is generally good).

CommentFileSizeAuthor
#2 og_aggregator-fixed-block-hiding-patch.patch1.48 KBTim_O
#1 og_aggregator.patch1.34 KBTaz
og_aggregator.module-hide-empty-block.patch766 bytesTim_O

Comments

Taz’s picture

Taz commented
Status: Needs review » Patch (to be ported)
StatusFileSize
new og_aggregator.patch1.34 KB

Thanks for bringing this to attention.

As always, there's more than one way to skin a cat. I've made a new patch with checks at different stages.

The problem mas more or less with the 'more link' always displaying, despite no returned results.

See patch. Test it on 1.4 and let me know how you go :)

Tim_O’s picture

Tim_O commented
StatusFileSize
new og_aggregator-fixed-block-hiding-patch.patch1.48 KB

Thank you, for looking into the issue. I tried to apply your patch against 6.x-1.4:

/testsystem/sites/all/modules/og_aggregator# patch < og_aggregator.patch 
(Stripping trailing CRs from patch.)
patching file og_aggregator.module
patch unexpectedly ends in middle of line
Hunk #1 FAILED at 185.
1 out of 1 hunk FAILED -- saving rejects to file og_aggregator.module.rej

with the .rej being:

/testsystem/sites/all/modules/og_aggregator# cat og_aggregator.module.rej 
***************
*** 185,200 ****
        if ($groupnode = og_get_group_context()) {
          $block['subject'] = t('Aggregator');
          $result = db_query_range("SELECT i.* FROM {og_aggregator_item} i JOIN {og_aggregator_feed} f ON i.fid = f.fid WHERE f.nid = %d ORDER BY i.timestamp desc", $groupnode->nid, 0, variable_get('og_aggregator_block_items_number',10));
-         $block['content'] = '<div class="more-link">'.
  l(t('more'), "node/$groupnode->nid/aggregator/feed", array('title' => t('View this feed\'s recent news.'))) .'</div>';
        }
-       $items = array();
-       while ($item = db_fetch_object($result)) {
-         $items[] = theme('og_aggregator_block_item', $item);
-       }
-       $block['content'] = theme('item_list', $items) . $block['content'];
      }
-     return $block;
    }
  
  
--- 185,207 ----
        if ($groupnode = og_get_group_context()) {
          $block['subject'] = t('Aggregator');
          $result = db_query_range("SELECT i.* FROM {og_aggregator_item} i JOIN {og_aggregator_feed} f ON i.fid = f.fid WHERE f.nid = %d ORDER BY i.timestamp desc", $groupnode->nid, 0, variable_get('og_aggregator_block_items_number',10));
+         if($result){
+           $items = array();
+           while ($item = db_fetch_object($result)) {
+             $items[] = theme('og_aggregator_block_item', $item);
+           }
+           if(!empty($items)){
+             $block['content'] = theme('item_list', $items);
+             $block['content'] .= '<div class="more-link">'.
  l(t('more'), "node/$groupnode->nid/aggregator/feed", array('title' => t('View this feed\'s recent news.'))) .'</div>';
+ 
+           }
+         }
        }
      }
+     if(isset($block)){
+       return $block;
+     }
    }

I applied you patch manually (by finding the position and doing those changes) and then made a patchfile myself (enclosed). Those files differ in the definition of line to be removed or so. I haven't really understand what my problem is here, any hints?

But I then was able to verify you changes once applied do the same, i.e. the block is hidden if empty - so cool with me otherwise :)

j0nathan’s picture

j0nathan commented

Hi,
Would it be possible to do the same to hide the tab if there is no feed in an OG?

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
commented
Title: Hide og_aggregator block if empty » Hide og_aggregator block or tab if empty

I'd love to see a patch that would hide the block or tab if it's empty. I have a site with lots and lots of groups, and only a few of them have feeds. The block is easier for me to control, because I'm overriding the display of the group pages through panels anyway. But the tab is hard to get rid of, and seems unnecessary when there's no content.

So: Would be great to see the hide-block patch included in a new dev, but I concur with #3 for a new feature request to hide the tab when empty.