When using "Appended page title as an URL" feature of Menu Breadcrumbs in combination with a Taxonomy View that includes terms with HTML entities such as & we ran into issues with the entities becoming doubly escaped.

Patch attached to fix issue. Now calls l() passing an option of 'html'=>TRUE

CommentFileSizeAuthor
menu-breadcrumb-append-page-title-url-double-encode.diff573 bytesharking

Comments

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Needs review » Reviewed & tested by the community

I'm experiencing the same issue, and applying this patch seems to fix it.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Thanks for reporting this and for making the effort to submit a patch.

It's actually a duplicate of #344449: Double-escaped strings causing improper output of special characters which was fixed already (and is available currently in the 6.x-1.x-dev release).

@harking, FYI it will help module maintainers (and get your code submitted easier) if you create patches from within the module directory, as per the instructions at http://drupal.org/patch/create - that way they can be applied more easily.

harking’s picture

harking commented

@2: thanks for the heads up. was trying to be helpful with a patch.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented

@harking, much appreciated - hoping simply to help ensure your future patches can be more easily accepted by maintainers.

Usually I'm on the other side of the coin too. I've been corrected myself on submitted patch formats more than once (I often forget the -p in -up!).

Cheers