In advanced_forum_settings_page() we have

    $options = array('' => '');
    $presets = imagecache_presets();
    foreach ($presets AS $preset) {
      $options[$preset['presetname']] = $preset['presetname'];
    }

If I happen to rename an imagecache preset, advanced forum "breaks". I have to visit this form again to reset the advanced_forum_user_picture_preset variable to the new name. I propose the variable be changed to store the imagecache preset id, rather than the name.

    foreach ($presets as $key => $preset) {
      $options[$key] = $preset['presetname'];
    }

We'll then need to get the preset name using imagecache_preset($preset_id) wherever we use the variable. And of course write an update_N function. Anything I'm missing?

If we agree this change is needed, I'll volunteer to write the initial patch.

Comments

michelle’s picture

I wasn't aware there was a separate ID. Your proposal makes sense and I'd be willing to commit a patch but I don't have 1.x installed anywhere to test it. It would be great if there's a second person out there willing to test.

Thanks,

Michelle

michelle’s picture

Status: Active » Postponed (maintainer needs more info)

Are you willing to write and test this...? I'll add it in if someone is willing to do the legwork. But I don't have a 1.x site and this is too big a change to just commit and pray. ;)

Michelle

michelle’s picture

Version: 6.x-1.1 » 6.x-2.x-dev
Status: Postponed (maintainer needs more info) » Active

No answer and I'm not going to write this for 1.x but will take a look to see if it's still an issue in 2.x.

Michelle

cedarm’s picture

Fair enough.

If anyone is still interested in a patch for 1.x speak up. We have no immediate need to get this fixed, so I probably won't if no one else cares.

michelle’s picture

Status: Active » Closed (won't fix)

I had a look at the code and theme_imagecache() takes the preset name, so that's why I use it.

Michelle