CVS edit link for kswan

I have written a module that is useful for me and I believe will be useful to others.

Description
===========
The super_nodereference module provides a very flexible method of using a
field that links to another node. This module is based on the CCK
nodereference module and integrates with CCK, but adds significant
flexibility.

Improvements compared to CCK nodereference
==========================================
- super_nodereference fields can be configured to link to any field ("primary
field") on the referenced node. The CCK nodereference field is hard coded
to the node title.
- super_nodereference fields offer very flexible autocomplete options. The
referenced node can be looked up using (1) a standard sql query on the
"primary field", (2) a preconfigured view filtered by the "primary field",
or (3) a preconfigured view with an exposed filter. The CCK nodereference
field doesn't recognize exposed filters.
- super_nodereference fields offer the option to store plain text if a
matching node is not found. CCK nodereference does not offer this option.

Limitations compared to CCK nodereference
=========================================
super_nodereference currently only offers the autocomplete widget.

Why not improve CCK nodereference?
==================================
The CCK nodereference module is in use on thousands of sites, therefore the
maintainers are not able to accept significant changes in functionality.
There is no plan for another major version for Drupal 6 (CCK 6.x-3.x is
strictly allowing only one new feature). I submitted a patch with part
of the functionality in super_nodereference to the CCK issue queue and the
CCK maintainers thought it should not be part of CCK
(http://drupal.org/node/167809#comment-1709748).

CommentFileSizeAuthor
#1 super_nodereference.tar_.gz20.89 KBkswan

Comments

kswan’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new20.89 KB

The module is attached.

avpaderno’s picture

Issue tags: +Module review

This seems to be a case of duplicate, which is what we try to avoid, especially to avoid confusion for the final users.

kswan’s picture

I understand that on a quick glance this seems to be a duplicate, but there are several issues in the CCK issue queue of people asking for these features. The maintainers have clearly stated that there is no intention of adding large features the 6.x branch.

Here are some issues that this module resolves.
#375690: Nodereference autocomplete doesn't match all of view's fields, #303209: How to hide the referenced node title in select list with view, #167809: Nodereference optional, #295477: Not exists nodes as text without link

A very basic use case that is impossible with the CCK nodereference module is:
Content type 1: Product
Product has a Title that is a name for the product. Product also has a CCK field named 'SKU'.

Content type 2: Invoice
Invoice has a nodereference field named 'product'.

On the Invoice entry form I need to be able to enter the SKU of the product. I can create a view that returns a list of Product SKU's and reference the view in the product field (on the Invoice content type). The title can be hidden by using the workaround explained in #303209: How to hide the referenced node title in select list. Now the product autocomplete will display SKUs.

The problem: If the user attempts to type the product SKU, no results will display. The autocomplete is searching for the products title.

This module offers significant functionality that clearly will not be added to existing modules in the D6 timeframe. Therefore, I don't believe it should be considered a duplicate.

avpaderno’s picture

See the following text reported in Apply for contributions CVS access.

I would like to fix bugs I find as I go or add new features to existing modules. The correct way to leave feedback for a module is to use the patch issue/queue system. And, in fact, for Drupal Core, this is the only way. Please note, this motivation message is appearing in more and more CVS applications and given the administrative overhead of engaging applicants via email, future CVS applications incorporating this will be declined on the basis that you didn't read this page.

kswan’s picture

I completely understand that. I have submitted several patches in the issue queues. As I said before, I submitted a patch for a portion of this modules functionality, but it was considered too extensive to be included in CCK. Obviously, yched and markus didn't consider this functionality a duplicate CCK nodereference.

I know the concern about duplicate modules. That is the reason I included a paragraph explaining why this isn't a duplicate.

Why not improve CCK nodereference?
==================================
The CCK nodereference module is in use on thousands of sites, therefore the
maintainers are not able to accept significant changes in functionality.
There is no plan for another major version for Drupal 6 (CCK 6.x-3.x is
strictly allowing only one new feature). I submitted a patch with part
of the functionality in super_nodereference to the CCK issue queue and the
CCK maintainers thought it should not be part of CCK
(http://drupal.org/node/167809#comment-1709748).

If this application is rejected, I will be happy to host this module on github or on my own site.

avpaderno’s picture

Status: Needs review » Closed (won't fix)

Basing on what reported by Apply for contributions CVS access, I am marking this report as won't fix.

basvredeling’s picture

Status: Closed (won't fix) » Active

I've reopened this issue because I can confirm that this is absolutely NOT a duplicate.

The normal node reference module only allows you to refer to titles. This module allows you to directly refer to fields within a referenced node. There was no way to solve this elegantly and simply without using this module.

I think the suggested module description is concise and to the point. For the attentive reader it also manages to distinct this module properly from the default node reference module.

avpaderno’s picture

Status: Active » Closed (won't fix)

Please re-apply for a CVS account; this report has been closed 9 months ago.

interestingaftermath’s picture

Component: Miscellaneous » miscellaneous

I also found this module very helpful and it's certainly not a duplicate.

gthing’s picture

Component: miscellaneous » new project application
Priority: Normal » Major
Status: Closed (won't fix) » Active

Denying this application was a mistake. This module is immensely useful and adds a new unique feature that expands CCK. It is NOT in any way a duplicate.

I am re-opening this and upping the priority so hopefully someone will take a better look at it.

Is there any reason to apply for a new CVS (or git) account when this ticket is already here?

jthorson’s picture

Priority: Major » Normal
Status: Active » Closed (won't fix)

If Kswan wants to revisit this application, he can migrate it to the Git Project Application queue as per the instructions below.

Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

I'm setting this back to closed ... if the applicant wants to re-initiate the application process, they may update the status and follow the steps outlined in the second link above.