The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.There's a *tiny* bug in the xmlsitemap_drush_command() function - it adds items to the variable $items without first defining it.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | xmlsitemap-n634730.patch | 650 bytes | damienmckenna |
Comments
Comment #1
damienmckennaQuick patch.
Comment #2
dave reidThat's odd. I thought this worked like hook_menu() where we start using $items without doing $items = array().
Comment #3
damienmckennaI thought it was standard PHP syntax that would throw an E_NOTICE if the variable didn't exist first?
Comment #4
dave reidIt's never done that for me, and I'm using error reporting with notices always during development. :/ Can you confirm it causes a notice?
Comment #5
damienmckennaSorry, my mistake, I thought I remembered PHP needed arrays to be defined first.
Comment #6
dave reidNo worries. You would think it would, but it doesn't care. A minor PHPWTF.