In order to use next-gen caching like ESI in Varnish, we need to allow for the cache plugin to alter the content, so that rather than the actual data itself, an ESI tag is returned. This would also be necessary to use NgineX's SSI+memcached system.

Currently panels_render_layout() does this for the whole page by saying $content = $cache->content; in the event that caching is triggered. We just need panels_get_pane_content() to do the same. It's a one-line fix. Patch attached!

CommentFileSizeAuthor
panels_pane_esi_cache.patch814 bytesjoshk

Comments

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ajayg’s picture

ajayg commented
Status: Closed (fixed) » Active

Since #655268: Cache problem with 3.x-dev / also present in 3.3 release undid this patch, shouldn't this be opened again? Or atleast marked as "need work"?

ajayg’s picture

ajayg commented
Status: Active » Needs work
cyberwolf’s picture

cyberwolf commented

Subscribing.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Version: 6.x-3.x-dev » 7.x-3.x-dev

Ok, so I'm assuming that this is also a D7 issue and that the fix was reverted.

If not please correct.

japerry’s picture

japerry
Location KOMK
commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

Drupal 7 is no longer supported, closing.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.