Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Original issue: http://drupal.org/node/537828
I stripped out a lot of text that was either duplicating what is on the main menu admin page, or seemed more appropriate to be left in the handbook.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | help_menu6.patch | 4.77 KB | arianek |
| #8 | help_menu_after6.png | 90.15 KB | arianek |
| #7 | help_menu.patch | 4.6 KB | batigolix |
| #7 | screenshot_016.png | 57.63 KB | batigolix |
| #5 | help_menu3.patch | 4.62 KB | arianek |
Comments
Comment #1
jhodgdonPatch review:
a) Very minor text comment:
Menus are a hierarchical collection of...Seems it should be "Menus are hierarchical collections" or "A menu is a hierarchical collection"?
Hmmm... I'm also a bit uncomfortable with the style of the rest of the sentence:
of links used to navigate a website, or sometimes to external websites.How about:
"A menu is a hierarchical collection of links, which can be within or external to the site, generally used for navigation."
b)
Custom menus can be either special site menus, or menus of external links, or any combinationToo many "or"s here?
c) Patch indentation is not consistent. Needs to use just spaces, not tabs, and all be indented the same (2 spaces per indentation level).
Other than that, I like it...
Oh, one other thing:
d) There will soon be only 5 default menus (I hope). See #637702: Get rid of Administration Shortcuts menu, which will get rid of the Admin Shortcuts menu. Just FYI...
Comment #2
jhodgdonRegarding (d), how about rather than listing what the default menus are, just saying that there are some defaults and you can see them on the Menus admin screen? Because these menus are set up when you enable various core modules, and it's possible not everyone will have the same set of "default" menus (for instance that admin shortcuts menu was installed by Toolbar).
Comment #3
jhodgdonI guess I forgot to change the status before, sorry.
Comment #4
arianek CreditAttribution: arianek commentedstab #2
Comment #5
arianek CreditAttribution: arianek commentedok, now i am just going to blame my text editor, there's no way i messed this many up! fixed indents
Comment #6
jhodgdonA few new comments:
a) " provides an interface to control and customize menus" ... What type of "control"? How about:
"provides an interface for managing menus"
b) "Default menus can be viewed and managed on the"... Can't all menus be viewed and managed there?
c) It seems like there are more uses than just adding new menus... Maybe there should be a section on some of the other tasks, like maybe "Menu management" that mentions you can add new items to existing menus, edit the link text, etc.
Comment #7
batigolix#6 a) done
b) done
c) done
Comment #8
arianek CreditAttribution: arianek commentedcleaned up some grammatical errors, punctuation standards, coding standards, and redundant links. i think this is ready to ship.
Comment #9
webchickLooks great! Committed to HEAD.