CVS edit link for cr0ss

I work with Drupal for a 1 year long. Visited DrupalCamp2009 and expect to visit Drupal FR conferences in future. Right now I have two ideas of module to contribute:

1. Top Commentators
Simple, but very usefull drupal for all the people who moved from Wordpress or another platform to Drupal. This module analysis count of comments from users and shows the best commenters list. Also could be used for advertise and motivate users for commenting actions.

2. PointBoard
Idea is realy simple and exists as party services. Board with some number of cells, in every one users can place advertise banner or logo ot their companies. It is an advertise module.

Comments

cr0ss’s picture

Component: Miscellaneous » Code
Status: Postponed (maintainer needs more info) » Needs review
Issue tags: +comments
StatusFileSize
new7.81 KB

First release of module Top Commentators attached to this comment.
Future releases will have much more exposed settings.

avpaderno’s picture

Component: Code » Miscellaneous
Issue tags: -comments +Module review

Please change only the status, when you upload new code; other metadata are not thought to be changed by the applicant.

cr0ss’s picture

StatusFileSize
new8.46 KB

Second release with more expanded settings.

matt2000’s picture

Status: Needs review » Needs work

IMO, You should really provide this as a default view for Views module instead of a hook_block implementation. But that's not necessarily a reason to reject this application.

If there's a compeling reason to use hook_block, then you should use $op = 'configure' instead of providing a separate config page through hook_menu.

cr0ss’s picture

Views is the way to reach this module purpose, but as I see Top Commentators module could be expanded with Gravatar or other modules integration and from this point hook is much usable and simple.

I take a look for adjusting setting to block configure page at the next release.

avpaderno’s picture

Top Commentators module could be expanded with Gravatar or other modules integration

The same is true for Views, which offers integration support for third-party modules. The number of modules that already offer integration with Views proves that.

cr0ss’s picture

I see what you mean. So, what I have to do to get CVS account and submit a module?

Target auditory of this module - bloggers, and I believe that they usually use only some basic module, not Views. Whatever, I'm currently reading the documentation of Views2 to get this module implement the default view.

UPD: Reseaching for the same situation led me to the module Relevant Content.

matt2000’s picture

I would mark this RTBC once hook_block('configure') is used, if everything else checks out.

If you want to be real clever and serve both audiences, you could wrap your hook_block code in a if (!module_exists('views')) . But again, I wouldn't consider that a requirement.

cr0ss’s picture

StatusFileSize
new8.21 KB

Configure is full of settings now. Please, take a look.
Working on a Views2 usage.

avpaderno’s picture

Status: Needs work » Needs review
matt2000’s picture

Status: Needs review » Needs work

Don't include License.txt. Drupal.org add this file to packages automatically, since all code is required to be GPL v2+.

You need to check_plain($user->name) before output, for example, in _top_commentators_get_list() when not using l(). This is a security issue, and the last thing holding back a green light, IMO.

Also, the indentation should match the code style guidelines. (Only 2 spaces, always), but based on discussions yesterday, I don't think we're going to hold back CVS accounts based on style any more.

A quick check of the forums shows that there are a number of users looking for a simple solution like this, so this module would be a welcome addition to the repository.

cr0ss’s picture

StatusFileSize
new2.49 KB

According to your quotes:
1. Get rid of License file
2. Check for 2-spaces style(no tabs anymore)
3. Covered $user->name with a check_plain, and it is only one user-dependent output

cr0ss’s picture

StatusFileSize
new2.21 KB

Carefully walked thought code and change:
1. .info file Description
2. CSS including

matt2000’s picture

Status: Needs work » Reviewed & tested by the community

Looks good to me.

avpaderno’s picture

Status: Reviewed & tested by the community » Fixed
    $user_count = ($show_number)?' (' . $user->count . ')':'';
    if(empty($user->homepage) || !$link_homepage)
      $items[] = check_plain($user->name) . $user_count;
    else
      $items[] = l($user->name, $user->homepage) . $user_count;

There should be a space after if, and the curly brackets are missing.

cr0ss’s picture

I Fixed that, KiamLaLuno.

Made everithing like its wrote here http://drupal.org/handbook/cvs/quickstart, but can`t see my module project page and module at the modules list http://drupalcode.org/viewvc/drupal/contributions/modules/

Did I do something wrong?

avpaderno’s picture

There is something that you missed, it seems.
The project page is created from the menu Create content, and then selecting Project; the creation of the project page is independent from the creation of the directory in CVS, and it is suggested to create first the project page (see http://drupal.org/handbook/cvs/projects).

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Closed (fixed) » Fixed
Issue tags: +PAreview: security

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.