Closed (fixed)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
17 Nov 2009 at 08:11 UTC
Updated:
17 Oct 2019 at 09:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
cr0ss commentedFirst release of module Top Commentators attached to this comment.
Future releases will have much more exposed settings.
Comment #2
avpadernoPlease change only the status, when you upload new code; other metadata are not thought to be changed by the applicant.
Comment #3
cr0ss commentedSecond release with more expanded settings.
Comment #4
matt2000 commentedIMO, You should really provide this as a default view for Views module instead of a hook_block implementation. But that's not necessarily a reason to reject this application.
If there's a compeling reason to use hook_block, then you should use $op = 'configure' instead of providing a separate config page through hook_menu.
Comment #5
cr0ss commentedViews is the way to reach this module purpose, but as I see Top Commentators module could be expanded with Gravatar or other modules integration and from this point hook is much usable and simple.
I take a look for adjusting setting to block configure page at the next release.
Comment #6
avpadernoThe same is true for Views, which offers integration support for third-party modules. The number of modules that already offer integration with Views proves that.
Comment #7
cr0ss commentedI see what you mean. So, what I have to do to get CVS account and submit a module?
Target auditory of this module - bloggers, and I believe that they usually use only some basic module, not Views. Whatever, I'm currently reading the documentation of Views2 to get this module implement the default view.
UPD: Reseaching for the same situation led me to the module Relevant Content.
Comment #8
matt2000 commentedI would mark this RTBC once hook_block('configure') is used, if everything else checks out.
If you want to be real clever and serve both audiences, you could wrap your hook_block code in a if (!module_exists('views')) . But again, I wouldn't consider that a requirement.
Comment #9
cr0ss commentedConfigure is full of settings now. Please, take a look.
Working on a Views2 usage.
Comment #10
avpadernoComment #11
matt2000 commentedDon't include License.txt. Drupal.org add this file to packages automatically, since all code is required to be GPL v2+.
You need to check_plain($user->name) before output, for example, in _top_commentators_get_list() when not using l(). This is a security issue, and the last thing holding back a green light, IMO.
Also, the indentation should match the code style guidelines. (Only 2 spaces, always), but based on discussions yesterday, I don't think we're going to hold back CVS accounts based on style any more.
A quick check of the forums shows that there are a number of users looking for a simple solution like this, so this module would be a welcome addition to the repository.
Comment #12
cr0ss commentedAccording to your quotes:
1. Get rid of License file
2. Check for 2-spaces style(no tabs anymore)
3. Covered $user->name with a check_plain, and it is only one user-dependent output
Comment #13
cr0ss commentedCarefully walked thought code and change:
1. .info file Description
2. CSS including
Comment #14
matt2000 commentedLooks good to me.
Comment #15
avpadernoThere should be a space after
if, and the curly brackets are missing.Comment #16
cr0ss commentedI Fixed that, KiamLaLuno.
Made everithing like its wrote here http://drupal.org/handbook/cvs/quickstart, but can`t see my module project page and module at the modules list http://drupalcode.org/viewvc/drupal/contributions/modules/
Did I do something wrong?
Comment #17
avpadernoThere is something that you missed, it seems.
The project page is created from the menu , and then selecting ; the creation of the project page is independent from the creation of the directory in CVS, and it is suggested to create first the project page (see http://drupal.org/handbook/cvs/projects).
Comment #20
avpaderno