I've created a patch where a user can set a dir/dcr video. Though Director Files are often games or interactive videos i think it can be useful.

I've added
- "Download Shockwave" link at bottom of "play page"
- mime type for both .dir and .dcr
- _video_get_parameters($node->serialized_data)

i've made the diff of the last CVS.

CommentFileSizeAuthor
#7 video_0.diff6.44 KBpsicomante
#6 video.diff6.34 KBpsicomante
#4 video.module_2.diff2.2 KBpsicomante
#3 video.module_1.diff2.2 KBpsicomante
#1 video.module_0.diff2.31 KBpsicomante
video.module.diff2.31 KBpsicomante

Comments

psicomante’s picture

psicomante commented
StatusFileSize
new video.module_0.diff2.31 KB

very stupid error. Different function names.

fax8’s picture

fax8 commented
Status: Needs review » Needs work

The patch looks a bit redundant.

In fact this code

     case 'dir':
        print theme('video_play_dcr', $node);
        break;
      case 'dcr':
        print theme('video_play_dcr', $node);
        break;

can be cleaned as

      case 'dir':
      case 'dcr':
        print theme('video_play_dcr', $node);
        break;

The same considerations to 

	case 'dir':
	  return 'application/x-director dir';
	case 'dcr':
	  return 'application/x-director dcr';

Please also update FILE_TYPES.txt in order to get this patch committed.

Fabio

psicomante’s picture

psicomante commented
StatusFileSize
new video.module_1.diff2.2 KB

I've cleaned the code and updated FILE_TYPES.txt

psicomante’s picture

psicomante commented
Assigned: Unassigned » psicomante
StatusFileSize
new video.module_2.diff2.2 KB

I've cleaned the code and updated FILE_TYPES.txt

fax8’s picture

fax8 commented

patches above does not updates FILE_TYPES.txt .
Please use directory diff .

Fabio

psicomante’s picture

psicomante commented
Category: task » feature
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new video.diff6.34 KB

I've made the directory diff. I've also correct a bug similar to 1.36 committ. It's about "multi-download" anchor.

psicomante’s picture

psicomante commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new video_0.diff6.44 KB

solved an incompatibility with IE

fax8’s picture

fax8 commented
Status: Needs review » Fixed

Committed to cvs. Thanks.

Fabio

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)