AliraSirin [alirasirin]

1.      $schema['junk_node'] = array(
       'description' => t('Stores junked node states.'),
   

   Schema descriptions should not be passed to t() anymore. See system_schema() for an example of what done by Drupal core code.

  variable_set('junk_hide_in_listings', 1);
  variable_set('junk_hide_in_views', 1);
  variable_set('junk_unpublish', 1);
  variable_set('junk_show_contents', 1);

There is no need to set Drupal variables to the default value; the default value is returned from variable_get() when the Drupal variable has not been already set.

2. function junk_menu()
   {
   	    
       $items['junk/clear'] = array(
       'title' => t('Clear junk confirm'),
       'page callback' => 'drupal_get_form',
       'page arguments' => array('junk_clear_junk_confirm'),
       'access arguments' => array('clear junk'),
       'type' => MENU_LOCAL_TASK,
       );
   

   Menu callback titles, and descriptions should not be passed to t() because that is already done by Drupal core code.

3.    t(''),
   

   An empty string should not be passed to t(); you cannot translate an empty string, which is an emptry string independently from the language set.

4.     if (variable_get('junk_unpublish',0))
       {
       	node_publish_action(&$node);
       	node_save($node);
       }
   

   See the Drupal coding standards to understand how a module code should be written. In particular, see the part about how to format the code.

5.     drupal_set_message("Node restored from junk", 'status');
   

   The string is not translated.

6. 	  '#options' => array(
   	    '0' => t('unlimited'), 
   	    '1' => t('1'), 
   	    '2' => t('2'),
   		'3' => t('3'),
   		'4' => t('4'),
   		'5' => t('5'),
   		'6' => t('6'),
   		'7' => t('7'),
   		'14' => t('14'),
   		'30' => t('30'),
   	  ),
   

   Is there a case where numbers need to be translated?

7. function junk_admin_settings_submit($form, &$form_state)
   {
   	variable_set('junk_lifetime', $form_state['values']['junk_lifetime']);
   	variable_set('junk_hide_in_listings', $form_state['values']['junk_hide_in_listings']);
   	variable_set('junk_hide_in_views', $form_state['values']['junk_hide_in_views']);
   	variable_set('junk_unpublish', $form_state['values']['junk_unpublish']);
   	variable_set('junk_show_contents', $form_state['values']['junk_show_contents']);
   	drupal_set_message(t('Your changes have been saved.'));
   }
   

   If the module would call system_settings_form(), that code would not be necessary.

As there are already projects with the same purpose, the proposed module should first resolve the points I listed.

1. The uninstallation function doesn't remove the Drupal variables used by the module.

hook_enable() is settings two Drupal variables that the code doesn't use; if those variables are used from another module, then the code should first verify if that module is enabled.

2. /*
    * Confirm deleteing junk form
    */
   function junk_clear_junk_confirm($form, &$form_state) {
     return confirm_form($form,
       t('Are you shure you want to empty junk?'),
   	'junk',
   	t('This action cannot be undone'),
   	t('Clear'),
   	t('Cancel')
     );
   }
   

If those variables are used from the module from which your module depends, then what I reported is not necessary. It's not clear if the names of the variables were not correct, so I pointed out that part of the code.
About the code reported in point #2, you wrote shure, when I guess you meant sure.

See comment #3, point #2.

I apologize for the time it took me before to review the code.