bug in fb_user.module line 72-74

I'll keep an eye out for this, but unless you can tell me exactly how to reproduce it I'm not sure how to fix it.

OK that helps. I don't think their should be entries with uid=0 in that table.

What are your fb_user settings? Do you have it create new accounts automatically?

I'm actually getting a similar issue around line 71. Facebook is trying to set the uid value to NULL, but the database is complaining, saying that the uid column does not accept NULL values.

fb_user.install line 27:

'uid' => array(
        'type' => 'int', 'size' => 'normal', 'not null' => TRUE,
),

fb_user.module line 69:

$result = db_query("UPDATE {fb_user_app} SET time_access=%d, session_key='%s', session_key_expires=%d, uid=NULL WHERE apikey='%s' AND fbu=%d",

Seems like a contradiction here... Maybe I don't understand the situation where would you want to set the uid to NULL... especially if you have automatic account creation.

This does need to be fixed.

The uid can be null, as users who authorize the app do not necessarily have a local account. So the fix will be to allow null and write an update function to change the db.

I hope this is the fix.

Index: fb_user.install                                                          
===================================================================
--- fb_user.install     (revision 2209)                                         
+++ fb_user.install     (working copy)                                          
@@ -25,7 +25,7 @@
       ),                                                                       
       'fbu' => array('type' => 'int', 'size' => 'big', 'not null' => TRUE, ),  
       'uid' => array(                                                          
-        'type' => 'int', 'size' => 'normal', 'not null' => TRUE,               
+        'type' => 'int', 'size' => 'normal', 'not null' => FALSE,              
       ),                                                                       
       'added' => array(                                                        
         'type' => 'int', 'unsigned' => TRUE, 'not null' => TRUE,               
@@ -128,4 +128,18 @@
   drupal_set_message(t('Note that if you see a warning about "Can\'t DROP ..."\
, it is safe to ignore that message.  See fb_user.install.'));                  
   return $ret;                                                                 
 }                                                                              
+                                                                               
+function fb_user_update_6006() {                                               
+  $ret = array();                                                              
+                                                                               
+  // uid can be zero or NULL.                                                  
+  db_change_field($ret, 'fb_user_app', 'uid', 'uid', array(                    
+                    'type' => 'int',                                           
+                    'size' => 'normal',                                        
+                    'not null' => FALSE                                        
+                  )                                                            
+  );                                                                           
+  return $ret;                                                                 
+}                                                                              
+                                                                               
 ?>                                                                             
\ No newline at end of file                                                     

Can you give me some quick background on why we want to set the uid to NULL? Not understanding that from a FB_Connect site perspective. Wouldn't this dissasociate the facebook account from the drupal user in a sense?

There are times when a user is interacting with the site, and the facebook id is known, but there is no local drupal account. I believe there was a time when I just used uid 0 in this case. I can't recall exactly the history of the decision to use NULL. I think it implies an association with no drupal account, rather than with the anonymous account.

The fb_user_app table, where this stuff is stored, is mostly for statistical purposes. It's possible to learn which facebook users have used the app. It also stores their session key which in some cases allows the app to interact with facebook on their behalf even when they are not logged in.

If you have more database know-how than I do, feel free to suggest the best approach for what to store in the uid column when there is no local account.

My plan now is to use 0 in the uid field, rather than allow null. Here's a patch to apply instead of the previous one.

Checked in for inclusion in beta4.