The example states that if you visit the url bar/baz the function
page_example_baz will be called. This is incorrect. If you specify the %
the argument will be required for the function to be called.

CommentFileSizeAuthor
#6 page_example_doc_issue_d6.patch11.22 KBilo

Comments

jhodgdon’s picture

Project: Drupal core » Examples for Developers
Version: 6.x-dev » 6.x-1.x-dev
Component: documentation » Documentation

The examples have been moved into a different project. Moving the issue to the right queue... haven't yet assessed the issue itself.

ilo’s picture

Assigned: Unassigned » ilo

This module requires more love, as permissions and menu access are wrong also. I'll try to make use of the D7 doc headers and make these two versions consistent.

jhodgdon’s picture

Note also that this issue was reported directly from api.drupal.org, which I think is not yet using this module (and is still reading from the old location of these example modules, isn't it?).

ilo’s picture

I have no idea about api.drupal.org, jhodgdon. Who should I talk about that? is there an irc nick I could ask for?
Thanks for the note, I'll review that also (once I know how to do).

jhodgdon’s picture

There's already an issue filed requesting that api.drupal.org be pointed to this module rather than the old location:
#619442: Use examples from Examples for Developers project on api.drupal.org

The person who can make this change (drumm) is aware of the issue and is working on it (I think).

ilo’s picture

Status: Active » Needs review
StatusFileSize
new11.22 KB

There are several changes in this patch. I just grabbed the D7 version (reviewed a few days ago) and backported to D6 so the changes in doc headers introduced in the d7 example are now in this version also.

I've just fixed the doc lines that generated this issue, and a few minor changes I've seen affecting also the D7 version. Once we get this one in, we can change version and I'll submit a patch for the d7.

Somethings I'd like to notice:
- this patch fixed the issue, and others as well (other references to ?q=bar/baz, the hook_help uri..)
- menu entries are now example/foo and example/baz (<- this one could be renamed to example/bar?)
- there a better explanation of menu system matching the uri.
- the test file worked as is for the d6 version.. good :)

I was unable to contact Drumm yesterday (tried on irc), so I can't include any other change regarding the doc to be considered for api.drupal.org. If you know how to proceed let me know, or just do (imo the only issue we should care about now is to point api.d.o. here and all these concerns about updating documentation/developers would disappear.. am I wrong?)

rfay’s picture

drumm asked for a couple of weeks before dealing with the api.drupal.org issue, so there is no need to push on this one right now. He responded on #617564: make api.drupal.org point to examples module on issues with examples modules.

rfay’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me. I'd say commit it.

ilo’s picture

Status: Reviewed & tested by the community » Fixed

#302146 Commited to DRUPAL-6--1
edit: update link

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.