Problem when uploading images with spaces in the file name [#635368]

Normally, after you have successfully attached an image to a taxonomy term, the term's edit page will show you the "current image" and present you with options to delete or replace it.

When I attach a taxonomy image which contains spaces in the file name, the file successfully uploads to the server, but it does not appear on the term's edit page afterwards. The module does not seem to recognize the image file.

When I replace the spaces in my file names with hyphens or underscores, then re-attach the images, everything works fine.

It would be nice if the module threw a validation error on the term's edit page, if the file name is not acceptable (ie. contains spaces or invalid characters). Alternatively, maybe the module could automatically re-name uploaded files by stripping out invalid characters?

I'm using Taxonomy Image with the ImageCache and Views modules. Taxonomy images which contain spaces in their file names are not appearing on the term edit pages or in my Views.

Does the Taxonomy Image module follow the same rules as the ImageCache module when examining the file names of uploaded images?

Thanks!

Comments

Comment #1

Anonymous (not verified) commented 17 November 2009 at 20:09

Sorry. I meant to ask:

Does the Taxonomy Image module follow the same rules as the CCK ImageField module when examining the file names of uploaded images?

It would be nice if these 2 modules could have consistent UI's and behavior.

Thanks!

Comment #2

Anonymous (not verified) commented 16 March 2010 at 18:02

Has anyone else experienced this problem?

Comment #3

pieterdc

Dutch

Ghent

commented 19 March 2010 at 13:49

Does installing the transliteration module fix your problem?

Comment #4

Alex Lawrence commented 1 April 2010 at 14:43

This problem made our whole development server freeze/crash. The server opened tons of Apache processes which used the whole memory. Only with luck I could kill the Apache over SSH. Right now I only know that this is the reason but I do not understand it. Actually the results of this error are simliar to this issue: http://drupal.org/node/437814

If anyone has a working solution to this it would be great. I will now look at the module myself and hope I find a solution.

Comment #5

Alex Lawrence commented 1 April 2010 at 15:11

Add

$_FILES['files']['name']['taxonomy_image_upload'] = str_replace(' ', '', $_FILES['files']['name']['taxonomy_image_upload']);

in the function taxonomy_image_image() before

$file = file_save_upload('taxonomy_image_upload', $validators, $directory, FILE_EXISTS_REPLACE);

However be aware that this fixes the error not the problem. I do not know why this module can cause a server to stop working just because of spaces in the file names. Don´t get me wrong, it was nice writing this module but this is the third time this module is causing problems.

Comment #6

Rajesh Ashok commented 28 April 2011 at 15:11

Here is the solution. http://drupal.org/node/438378#comment-2052128

I also faced the same problem. Now its solved.

Comment #7

nancydru

she/her/hers

English

Boston

commented 28 April 2011 at 15:25

Technically spaces are not allowed in file names. You might want to have a look at the Transliteration module as well.

Comment #8

yash_khandelwal

English

commented 8 April 2017 at 10:22

Issue summary:	View changes
Status:	Active	» Closed (works as designed)

Comment #9

yash_khandelwal

English

commented 8 April 2017 at 10:22

Use hook_file insert. See below example.

function demo_attachment_file ($form, &$form_state) {

  $form = array();
  $form['issue_file'] = array(
    '#title' => 'Attachment :',
    '#type' => 'managed_file',
    '#upload_location' => 'public://images/',
    '#upload_validators' => array(
      'file_validate_extensions' => array('png', 'jpg', 'jpeg', 'JPG', 'JPEG', 'gif'),
    ),
  );
return $form;
}

**
 * hook_file_insert()
 * @param type $file
 */
function demo_file_insert($file) {
  $new_name = str_replace(array(':', '\\', '/', '*', ' ', '(', ')'), '-', strtolower($file->filename));
  $parts = pathinfo($file->filename);
  if (in_array(mb_strtolower($parts['extension']), array('jpg', 'jpeg', 'gif', 'png'))) {
    $uri = 'public://images/' . $new_name;
    $file = file_move($file, $uri);
  }
}