Validation Error On Comment Preview

I thought the code rlated to the "thread" comment field looked suspicious because it changed the database format. I tested it by changing a comment to the old format. The error still happened, so that's not the problem.

I verified that the content of the comment in the database doesn't change while previewing repeatedly. I'm starting to suspect unintended recursion. Some piece of code is being called with a bad "edit" reference. I'm not a PHP programmer so I don't know how references are done, but I doubt arrays are passed by value.

The error only happens when I reply to a node and not to another comment. The problem must be in an execution path that differs between node/reply and comment/reply. Comment_reply looks likely. Here's the code from 4.6.6:

    if ($pid) {
      $comment = db_fetch_object(db_query('SELECT c.*, u.uid, u.name AS registered_name, u.picture, u.data FROM {comments} c INNER JOIN {users} u ON c.uid = u.uid WHERE c.cid = %d AND c.status = 0', $pid));
      $comment = drupal_unpack($comment);
      $comment->name = $comment->uid ? $comment->registered_name : $comment->name;
      $output .= theme('comment_view', $comment);
    }
    else if (user_access('access content')) {
      $output .= node_view($node);
      $pid = 0;
    }

And the code from 4.7.0:

      if ($pid) {
        if ($comment = db_fetch_object(db_query('SELECT c.*, u.uid, u.name AS registered_name, u.picture, u.data FROM {comments} c INNER JOIN {users} u ON c.uid = u.uid WHERE c.cid = %d AND c.status = %d', $pid, COMMENT_PUBLISHED))) {
          if ($comment->nid != $nid) {
            // Attempting to reply to a comment not belonging to the current nid.
            drupal_set_message(t('The comment you are replying to does not exist.'), 'error');
            drupal_goto("node/$nid");
          }
          $comment = drupal_unpack($comment);
          $comment->name = $comment->uid ? $comment->registered_name : $comment->name;
          $output .= theme('comment_view', $comment);
        }
        else {
          drupal_set_message(t('The comment you are replying to does not exist.'), 'error');
          drupal_goto("node/$nid");
        }
      }
      else if (user_access('access content')) {
        $output .= node_view($node);
      }

Could the removal of this line have caused the error?

      $pid = 0;

Thank you for filing an issue! Please include as much info / insights in the issue itself.

--
The Manual | Troubleshooting FAQ | Tips for posting | Make Backups! | Consider creating a Test site.