Posted by batigolix on November 18, 2009 at 8:04am
6 followers
Issue Summary
Background: http://drupal.org/node/537828
Here is the patch for updating the Tracker module's Help function. Contains reformatting and some rewrites.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| tracker_module.patch | 2.45 KB | Idle | Unable to apply patch tracker_module.patch | View details |
Comments
#1
The last submitted patch failed testing.
#2
A few comments:
a) All the lines should have the same indentation.
b) This line should have .= in it:
$output = '<h3>' . t('About') . '</h3>';c) This is a bug in the Tracker module in general, and not in the help file specifically, but I thought we were no longer using the term "posts" when referring to content? So why is the tracker page still called "Recent posts", and why does it display "no posts" when there aren't any yet?????????
#3
I filed (c) as a separate issue: #637930: Tracker screens still using "post"
#4
ok. i shall wait for the outcome of #637930: Tracker screens still using "post" before redoing the helptext
#5
i wouldn't wait on it, there are blocks still using the name posts as well... they'll all get changed eventually, but we shouldn't hold out on it.
#6
worked around the "posts" problem
#7
The last submitted patch failed testing.
#8
The tracker module issue was done, so this patch needs an update.
#9
trying to male the patch apply
#10
overhauled this one - added some more content, cleaned up and "drupalized" the language. needs reviewing!
#11
I like it, and the patch looks clean to me. :)
#12
One minor omission: There's also a "My recent content" tab where a user can track their own content. This is one of the most frequently accessed pages on Drupal.org, so it's worth mentioning in the help, methinks. :)
So after "...occur in the text, or when new comments are added." I added: "The My recent content tab limits the list to the currently logged-in user." I would completely understand if this horrifies someone and they'd like to create a follow-up patch to un-geekify this a bit. :P
Also, because I'm totally pedantic like that, I removed the extra space before "For more information..." ;)
Committed to HEAD!
#13
i think it's tolerably geeky ;-) thanks, missed that bit!
#14
Automatically closed -- issue fixed for 2 weeks with no activity.