Closed (works as designed)
Project:
Creative Commons
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Nov 2009 at 08:53 UTC
Updated:
5 Aug 2010 at 06:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
balleyne commentedYou mean, no icon is appearing when it's "All Rights Reserved?" That should actually be the expected behaviour right now. "zero.png" is for the CC0 public domain waiver. There's currently no icon for "all rights reserved."
But you bring up a good point -- maybe there should be.
I'd just taken the images from the creativecommons.org downloads, so we'd have to fight icons to use for "all rights reserved" from elsewhere. I could see the tiny icon being pretty straightforward (e.g. (C) ), but I'm not sure what the buttons should look like.
Thoughts? Or maybe I'll just leave it as is for now...
Comment #2
c-c-m commentedYes, I made a mistake. What I wanted to say is that when Copyright license is selected an icon should be displayed.
Something like the one attached here (I made a custom icon based on the CC icons which has inverse colours and the text says "copyright" I wish I could have the originals to make a better results... :S)
Could you do that, please?
Comment #3
turadg commentedI object to using the (c) Copyright graphic because it implies that there is no copyright with the other license. In fact, Creative Commons licenses depend on copyright law. All CC-licensed works are copyrighted. That is how they enforce their license terms.
The "All Rights Reserved" license (which is what I think you mean when you write "Copyright" license) means that no rights are granted, they are all reserved. There is precedent for using the (C) graphic for ARR (http://seesmic.com/docs/CreativeCommons.html) but I think we should try to come up with something better.
Why not leave the graphic out? ARR is implied when no license is specified.
Comment #4
c-c-m commentedAlthough default ARR may be implied when no license is specified, I think it would be better to display it, even though that can be seen reduntant. Some people think that everything on the Internet is public and therefore subject to be used as they want, others are a little bit more aware about copyrights and think that when no license is displayed that means that it's Public Domain.
In addition I'm using a view with a "license type" field to list a series of content and it looks weird when nothing is displayed.
PS: yes, you were right: I meant All Rights Reserved
Comment #5
c-c-m commentedHello,
It looks you're quite busy right now. Could you please tell me where can I make a modification of the code in order to display an icon when "All Rights Reserved" is selected. I think it's quite important to display something instead of leaving that field empty.
Regards
Comment #6
balleyne commentedComment #7
toemaz commentedI used a tpl to override the field theming. In there, I did whatever I wanted to have. Could be an option to temporary solve this issue.
Comment #8
kreynen commentedSwitching this back to "by design" since the design is to serve as many use cases as possible, but with a framework that allow users like toemaz to customize the module for their specific use case without modifying the module code itself.
@toemaz Other users might find your tpl code helpful. If you have time, please post it using the <code>YOUR .TPL CODE<code> as an attachment. Using <code> will allow you to leave the rest of you HTML and PHP as is and will look like...
Comment #9
toemaz commentedYou'll need to use the cc release from after 27th of July 2010 which has an implementation for hook_theme(). Now you can override the theming: creativecommons-node-license.tpl.php.
Concerning theming a view field, e.g. views-view-field--license-uri.tpl.php, use something like this: