First, my apologies if this is a) not counted as a bug and b) this issue has been raised. I search issue queue and did not see conflicting entry.
I am new to Panels, Panels 3 being the first exposure. Thank you for a great and powerful module.
I noticed after creating a panel page which included the creation of a drupal menu entry from within the panel, if after saving I do anything to the menu drupal resulting menu entry eg change the name of the menu item, this is not reflected back in the panel page.
It's a minor irritant, but thought you'd like to know my experience.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | doc-menu-636052-10.patch | 831 bytes | rivimey |
| #7 | doc-menu-636052-07.patch | 910 bytes | mike.roman |
Comments
Comment #1
merlinofchaos commentedI'm not sure if this is really a bug or not. The menu module UI to modifying menu stuff is kind of an aftermarket, so to speak. It operates at a layer after the Panels menu stuff operates.
I suppose Panels could take a look at that when it loads things, but it isn't allowed to actually touch those items (because that data can't be exported) so I worry that reflecting it could be problematic because you can't change it.
Comment #2
Brian Tastic commentedYour reply is helpful - thanks.
It sounds like a saftey protection for Drupal menu system/API from what you are saying?
I think this should be highlighted in the Panels 3 documentation should it be written.
Thank you for the reply
Comment #3
merlinofchaos commentedIt's not really safety, just a separation of API layers, and the fact that in order for exports to work, Panels (really, Page Manager) shouldn't do anything that affects the actual database. Otherwise, when you use default pages in a module, their data won't be correct.
Comment #4
merlinofchaos commentedAdd to documentation tasks.
Comment #5
japerryComment #6
mike.roman commentedLooking into the documentation of this at Drupal Midcamp
Comment #7
mike.roman commentedI actually had to go into Ctools to add the necessary documentation. I added "Renaming the menu item using the Drupal menu system (admin/structure/menu) will override this, even if it is renamed again here." to the field description for "Title" in the Panels "Menu" tab. This should make it clearer that the Drupal menu system controls Panels menu items.
Comment #8
joshmillerPatch has been reviewed. Applies and reads well. Basically describes default behavior in a way that will help set user expectations. Excellent job @mike.roman!
Comment #9
damienmckennaMoving the issue to the correct project.
Comment #10
rivimeyPatch applies cleanly on 7.x-1.x
Improving help text is good and to be encouraged. However, the rest of the file uses long-line-strings rather than breaking them up, and this patch includes a lot of additional spaces, and newlines, into the text, which I feel is undesirable for translation and consistency purposes. Consequently, I attach a new patch where the lines are simply joined up again.
Comment #11
rivimeyComment #12
joshmillerSo much effort for one line of text :) Patch from #10 is still RTBC'ed ... though, Rivimey, I would have perhaps set it back to needs review.
Comment #13
rivimeyHi Josh, I know/agree.
I left it as RTBC simply because the new patch is not a substantive change to an already-reviewed patch (and "so much effort'), but if others disagree and wish to review, that is also fine.
Comment #14
damienmckennaComment #15
damienmckennaLooks good :)
Comment #17
japerryCommitted