I appreciate your work on this module, but I feel like there's a slight issue. Perhaps I'm misunderstanding something, but I've set certain users to have access to view normal and hidden edits. As such, I would expect the latest edit to show up under the comment. However, because $messages is stored as an associative array of normal and hidden, it goes to the second part of your theme function using a fieldset. This makes sense, but it only displays the hidden edit and not the normal edit, even if the normal edit was done more recently. I can just override the theme function, but I figured it would make more sense to have the default display the latest, or, since it looks like you're using a fieldset, display both. I simply changed my code (at the bottom of comment_edited.module) from:

$fieldset['#value'] = '<div class="last-edited">'. $message .'</div>';

to

$fieldset['#value'] .= '<div class="last-edited">'. $message .'</div>';

So the values concatenate instead of replacing. Did I just misinterpret the the purpose? Thanks.

Comments

BillyMG’s picture

Title: Displaying Messages » Displaying Correct Edited Messages

Changing the title to make it more accurate, my apologies.

snufkin’s picture

Version: 6.x-1.2 » 6.x-1.x-dev
Status: Active » Fixed

It does make sense, I committed to the dev version. I will roll it out as a stable release hopefully early next month depending how soon i can get around to test the changes.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.