| Project: | Taxonomy Title |
| Version: | 6.x-1.2 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Found this module very useful for my projects and used it today the first time. As it was very small I's like to provide a German translation very soon. Before I provide any translation I'm mostly doing translatable string reviews...
Therefore I've done a full code review as the module wasn't that big... and fixed all code style issues, translatable string bugs and fixed SQL code style bugs plus a hook_help bug and so on... this patch touches many lines, but this is often only a missing blank and some things that make code more speedy and more specific (hook_preprocess_page and hook_form_FORM_ID_alter) as we know them and there is no need to fire on all available forms and preprocess hooks.
Code wise it should all be ok, I will do a test tomorrow on my DEV site.
| Attachment | Size |
|---|---|
| taxonomy_title_review.patch | 6.81 KB |
Comments
#1
Fixed a missing bracket.
#2
Looks like there is no need to check_plain the title. Removed the check_plain.
#3
New patch. This one also fixes the bug that the title field is shown on the term delete page.
#4
@hass, thanks for all your work on this, I look forward to receiving your translation :-)
Committed to dev branch, new release shortly.
Jen
#5
It looks like my fixes are not in 1.2
#6
#7
New patch attached. Please give me some time to update the translation file after the commit and before the next release.
http://drupal.org/coding-standards
http://drupal.org/project/coder
#8
Ok, committed the new patch, but may issue a new release for two other critical issues.
#9
What else is broken?
#10
#11
Automatically closed -- issue fixed for 2 weeks with no activity.