Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.When the Continue button is clicked on the checkout page and there is a problem, such as not having put the credit card info in, the FedEx quote remains but the logos disappear.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 636792-shipping-quote-title-consistent.patch | 1.11 KB | longwave |
Comments
Comment #1
tr commentedInteresting. Do you find that to be true of every shipping method, or just FedEx? You mean the "Review order" button, not "Continue", right? And which pane are you talking about, the shipping quotes pane or the payment methods pane?
Comment #2
tr commentedI can confirm this behavior for several different shipping methods. The logo disappears from the shipping quote displayed in the Payment methods pane. The shipping quotes pane, however, properly displays any logos when the page is reloaded on an error.
The culprit is some code in uc_quote.module. Namely this line, which is line 1085 in the UC 2.0 release:
This line is using the raw name of the shipping method rather than the themed output of the shipping module. Not sure exactly what the fix is yet, but since it's a problem in uc_quote and is not specific to the FedEx module I'm moving this issue to the Ubercart queue.
Comment #3
j. ayen green commentedThe site is only using FedEx and USPS, and the USPS doesn't show a logo. It's the Review Order button. I'm not sure about the pane question...the logos are in the quotes pane, but what I meant was if something on the page causes the page to remain loaded after the Review Order button is clicked (in this case, we noticed it when the credit card info being insufficient caused the page to remain loaded).
Comment #4
j. ayen green commentedOh, one other thing. Click to have the quotes (re)generated brings the logos back.
Comment #5
tr commentedWhat I said in #2 is that I can reproduce the problem for other shipping methods. In particular, I tried FedEx, Canada Post, and UPS, which are the only three shipping methods that provide logos. I get the same failure for ALL of them. PLUS, I traced the exact line of code which is causing the problem, and that code is in uc_quote.module. That is why I changed the title and reassigned this to the Ubercart issue queue. Is there some reason you believe I'm wrong here?
Re: #3. Logos show up in two places, one is in the shipping quotes pane on the checkout page, right below the "Click to calculate shipping" button. The other place is in the payment methods pane on the checkout page, right below where it says "Select a payment method from the following options." then shows the "Order total preview" with the "Subtotal", shipping method (with logo), and "Order total"
What I see is that the error you describe only occurs in the payment methods pane. The logos *always* appear for me in the shipping quotes pane. The logos *do not* appear in the payment methods pane if the form validation fails, like you said, but they *do* appear in the shipping quotes pane. After form validation failure, clicking the "Click to calculate shipping" button restores the logo in the payment methods pane.
If you think this does not describe what you are seeing, then you should attach some images to your next post to show exactly *where* you expect to see the logo.
Comment #6
j. ayen green commentedNo, I didn't say you were wrong about anything. I was just clarifying what I had written. You're correct, it -is- the payment method. Sorry. I accepted the description of my coworker without checking it myself. Appreciate your looking at it!
Comment #7
tr commentedThen changing title again and moving back to Ubercart queue.
Comment #8
tr commentedMoving to 7.x-3.x.
Comment #9
longwaveI don't think this is an issue in 7.x-3.x.
In 6.x-2.x no logos seem to show up at all for me in the payment pane, but there is an inconsistency in the shipping method titles there, depending on whether you are seeing the checkout page for the first time or not, and whether you have clicked the retrieve quotes button or not. The attached patch improves this a bit, but fixing this fully would mean major changes to uc_quote, which are not worth doing now.
Comment #10
longwaveThe above patch risks breaking other shipping methods, and with no other movement on this issue for three years there seems little point changing this now.