uc_cart_remove_item passes wrong item to hook

kalgalath - November 19, 2009 - 00:36
Project:Ubercart
Version:6.x-2.2
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

This is my first issue/bug report so any advice or feedback would be great!

The item passed to hook_cart_item() may not be the right item. This function re-pulls the items from the database. Upon doing so, it only matches on the node id and cart id. This leads to the wrong item possibly be passed along to the hook. It should also match on serialize($data). I've attached a patch that addresses this issue.

#1

kalgalath - November 19, 2009 - 00:39
Status:active» needs review
AttachmentSize
ubercart-636816-1.patch 1.09 KB

#2

TR - March 14, 2010 - 19:00

Bumping this one up so I remember to test it.

 
 

Drupal is a registered trademark of Dries Buytaert.