Closed (fixed)
Project:
Drupal core
Version:
x.y.z
Component:
theme system
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 May 2006 at 17:05 UTC
Updated:
6 Nov 2006 at 15:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
Robrecht Jacques commentedSeems correct to me: as there can be multiple pagers on one page, one would have multiple divs with the same id, which is not allowed. So making it a class would solve that.
Of course the .css file also needs to be altered to use .pager instead of #pager.
Patch attached.
Comment #2
beginner commentedThe argumentation makes sense.
I grepped but couldn't find other occurrences of #pager or id="pager" other than the ones in the patch.
I don't know how this would affect custom made themes, though. I guess very few, if any, would theme #pager, so I think it is safe.
I set as RTBC, but I don't know the exact policy on such changes.
Comment #3
dries commentedHow can there be multiple pagers on the same page? How do you make the URLs of each pager different so the pager code knows what pager is clicked? AFAIK, we don't support multiple pagers on the same page, but I might be wrong ... please clarify how you use this so we can evaluate the usefulness/correctness of this patch.
Comment #4
yched commentedDries :
on http://api.drupal.org/api/HEAD/function/theme_pager
and http://api.drupal.org/api/HEAD/function/pager_query
It seems we do support multiple pagers on one page.
I think Views support this, for instance.
Plus, even with only one paged content, I guess you might want to have the pager above _and_ below a large table.
Comment #5
dries commentedAh, makes sense.
Comment #6
dries commentedCommitted to CVS HEAD.
Comment #7
edmund.kwok commentedAttached patch for 4.7.4.
Comment #8
killes@www.drop.org commentedI am not sure I should apply this to 4.7. Wouldn't this break any custom CSS? To have two pagers on one page is probably rarer than theming the single pager that is usually there.
Comment #9
webchickAgreed. Any existing theme which had styled the pager would cease to work with this patch. Kind of a mean thing to do in a stable version of Drupal.
Comment #10
edmund.kwok commentedI agree also, found at least 30 themes using #pager. Well, set this to fixed then? Btw, documentation needed for 4.7->5.0 themes in regards to the original patch that Dries committed.
Comment #11
gerhard killesreiter commenteddone
Comment #12
(not verified) commented