If there are non-ASCII-Characters or Whitespaces in the sourcename of node-images teaserthumbnails fails to recognize. It also fails, if the (internal) image comes with an absolute path (on my drupal-installations ALL image-pathes are absolut!).
Reasons: buggy regexpressions and no handling for internal absolute pathes.
Please check the attached file with some enhancements or go to
http://sysout.twoday.net/stories/6051581/
or http://pastebin.ca/1678217
My applied changes will fix the issues.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | teaser_thumbnail-637714.patch | 4.28 KB | 20th |
| #2 | Drupal_teaser_thumbnail_6-x-1-5_debugged.zip | 12.91 KB | tech-o-matic |
| teaserthumbnail.zip | 3.95 KB | tech-o-matic |
Comments
Comment #1
tech-o-matic commentedComment #2
tech-o-matic commentedMore fixes (caseinsensitiv recognition of fileextensions)
source at http://pastebin.ca/1703463
Comment #3
20th commented@tech-o-matic:
Hi! The project maintainer is somewhat missing, so I thought I'd help you a little.
Drupal development is based on patches, you shouldn't give the project maintainer you version of the code, you should give them information about difference between the yours and theirs. More info about patches here - http://drupal.org/patch
I have prepared the patch for the version you uploaded in the second comment.
First of all, you need to change your code, so it would follow Drupal coding standards. And either remove the watchdog() call inside a _teaserthumbnail_process() function, or make it more informative.
Could you also check the #637492: Thumbnail in nodes from FeedAPI issue? Maybe it would be possible to integrate that patch into yours.
Comment #4
saitanay commentedeven the 'debugged' version doesnt seem to work,.
great module,. wasted
Comment #5
hunvreus commentedUsing the latest version of Teaser Thumbnail I never ran in any problem with non-ascii characters and white spaces; what OS are you running your Drupal install on? I know (from past experience) that Windows has a somehow original way of dealing with file names when they contain foreign characters or white spaces, but even when my original pictures contain chinese characters and additional spaces the module properly create a teaser thumbnail. Is there any entry create in the teaserthumbnail table after you submitted the node?