Look into the following (notes):

  • template for each column or template for the whole footermap
  • implement something other than theme_links, which is not that great. maybe there's a contrib module out there already?
  • other code changes to make it easier to implement nifty styling that people want.
CommentFileSizeAuthor
#1 637734-render-array-and-theme.patch11.55 KBmradcliffe

Comments

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Postponed » Needs review
StatusFileSize
new 637734-render-array-and-theme.patch11.55 KB

In Drupal 7+, we should be using a render array. This will allow greater flexibility for themers to adjust menu headers and what not. I think this solves some of the theming and/or scope issues.

This patch works fairly well.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed

Committed to dev branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Closed (fixed) » Needs work

There are some issues with this still...

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs work » Fixed

Or just bad documentation. The caching/language patch changed things and I need to update docs.

finedesign’s picture

finedesign commented

First, thank you for this module.

I hope this is the place where I should add feedback. I noticed related posts are directed here.

I just tried the latest dev branch of the module and I see the additional classes, but it still doesn't provide a wrapper or grouping around menu sections.
I need:

<div class="wrapper">
<ul>
<li class="top">First MM Item</li>
<li>Misc link 1</li>
<li>Misc link 2</li>
<li>Misc link 3</li>
</ul>
</div>

And even the ul or li is not necessary as long as there are classes. I just need something to separate the main sections from one another.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

robinho007’s picture

robinho007 commented

Can any1 upload the right folder with the precise patch? can't get it to work with more than 1 column