Posted by jovemac on November 19, 2009 at 11:41pm
| Project: | Storm |
| Version: | 6.x-1.x-dev |
| Component: | Storm Project |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
Hi!
Is it possible to enable email notifications, when ever a modification or a new project is being assigned to a person/team to all the persons involved wtih that change
Comments
#1
Once #332555: Token support- proof of concept is complete, then you'll be able to do this with Actions (ships with Drupal core).
We may integrate a few default actions too so you don't have to set it up. However, it needs the token support first.
#2
Here a "small" module to allow the email notification for "assigned to" person. It works with the latest storm's release.
#3
StormMail is a nice enhancement to the storm project, nice job on this module so far... I'm trying it out and wanted to give some feedback.
Its easy to load and use, but on my first attempt of sending email, it was blocked by Norton Antivirus. This from a dev WAMP laptop. I'm pretty sure I don't have the email setup right on it...
I also loaded it to an ISP dev site (with cpanel) and it seems to work just fine, except for the fact that when looking at the email recieved to my gmail account, I can't read it because it is in what I assume is Italian...?
Is there an easy way to switch the module so the recieved email is English? I'm not sure wheather this is a Drupal setting or something with StormMail.
#4
@db102:
There is a bit of background to StormMail on #595276: Assign to fields for tasks and tickets.
As far as I know, the module is in Italian. If you are going to use it, would you be able to translate the phrases and repost? That way everyone can use it.
#5
@magnity;
Thanks for clueing me in. Attached is stormmail.module file translated from Italian to English. It works for me off ISP server.
#6
I'm also translating it. I found a bug myself: when new project, ticket, task is created the url to the content isn't complete. I'm working to fix it, please post here bugs and extensions request.
#7
Here the new version of the modules, some bug fix. Attached the eng version.
#8
Module works great and is very easy to edit.
Typo: "tikcet" should be "ticket"
if($node->type == "stormticket") {stormmail_all($node, "tikcet", "up");
}
Also, some translations are missing for
$message['body'] = t('Hello ').$params['name'].t(', ').t('The e\' state as soon as assigned the following one ').$params['type'].(': ').$params['url'].t(' dal titolo: "').$params['titolo'].t('"');
although most users would like to customize this anyways
#9
Sorry for mistakes, I'll update the translation.
Thank you for your feedback ;)
#10
According to Magnity and #671622: Remove duplication between name and fullname, the fullname field will eventually be removed, so stormmail will have to be rewritten to pull name and not fullname.
$result = db_query("SELECT * FROM {stormperson} WHERE nid = %d ", $assign);if ($data = db_fetch_object($result)) {
$emailTo = $data->email;
$name = $data->fullname;
}
Also, thought about ability to email the status of projects, pulling in the status value, or also for sending different messages based on status. For example if status is completed, "Your project [xxx] has been completed."
What do you think?
#11
I think we should probably work on trying to include the functionality from stormmail into the storm download. It seems like it has been very popular. And then we can ensure any Storm changes are reflected in it as well.
Would anybody be willing to make the stormmail module into a patch for storm? I guess ideally we should integrate it into the existing modules rather than needing users to switch on another module.
#12
#11 @Magnity:
Great, I can help you in a few days (a lot of work now :) ).
#13
Is this being actively worked on?
It is a feature I definitely think would benefit this module.
I tried installing the zipped module above and I am having a bit of trouble. Should I be able to see/configure it from the Storm admin page or is this a process that simply runs in the background?
#14
Hi,
Just found this. I agree, this is a very important feature for one of my projects as well. I'll look at it and see what I can do.
#15
Currently the module just adds an "email: yes | no" to tasks/projects and will send an email out to person under "assigned to:" for that node. There is nothing else to customize. At the moment, the only way of editing what the email says is by editing the module itself.
I've been wanting to mess around with it and see what can be changed but haven't found time.
Any ideas on what you all would like to see?
#16
The biggest thing for me would be automatic emails to group/team members when a new project has been inserted and/or updated.
This would allow a manager to post a project and assign it to a team member without the manager having to send a separate email describing the project again.
In addition to this (and I know that this isn't specific to this part of the module), it would be nice to be able to assign multiple people to the same project. In addition it would be nice to have multiple managers assigned to the same project.
#17
Great module. It's doing almost exactly what I want. I'm building an intranet portal so the company can record tasks assigned to projects and monitor who's working on what. Tasks are sent over email to the user it was assigned to.
I don't expect all the employees to connect to the intranet, that's why I want it to be mostly email based. I'll use the Mailhandler module to create nodes. Like oxiclean, what I'm missing is this feature to send notifications when a task/project is created/updated to all the users assigned to this project.
How about the notification module ? It seems to do just this.
#18
How about integration with the Notification framework? as an example auto subscribe team members to any entity they are associated.
This is the project page: http://drupal.org/project/notifications
#19
I've added some changes to get the email notification to pick up team members. I need to make it cvs/svn friendly (ie make it into a patch). But in the meantime I'm attaching it as txt file, if anyone could turn this into a patch (and review it for mistakes of course) for me I'd really appreciate it.
#20
Just to make it easier to review code, please could you review http://drupal.org/coding-standards:
- Indentation using 2 spaces rather than tab
- Removal of debug lines such as dvm()
- Names should be in English
Also, as you mentioned, it needs to be in patch form for committing (http://drupal.org/patch/create). As part of that, the stormmail prefixing should be changed to integrate with one of the existing storm modules.
#21
Status change.
#22
Hi Magnity,
I ran the module through coder, now I just need to figure out how to get tortoise svn working on my machine and I can submit this a patch.
What did you mean by stormmail prefixing?
#23
Ok. Here is my first attempt at a patch. Be gentle :)
I still don't know what storm module prefixing is.
#24
Is this comparing against a CVS checkout? It seems to be adding and removing bits of stormmail functionality, whereas I suspect it should only be adding.
Re the prefixing, what I mean is that this is currently set out as its own module, the stormmail module. I'd prefer if this could be added to one of the existing modules. Then I'd be seeing functions such as storm_xxx or stormproject_xxx.
#25
Let me l explain what I did.
I created a repository on my local machine. Put the code from the zip into it and checked it out. Deleted the code, added my changed code. Right clicked tortoise svn and told it apply the patch.
Should I have done that or instead have checked out storm from the cvs and then added my changes?
Is so, (I know this is an endlessly noobie question) what's the url for the checkout? And does it matter that I'm using tortoise svn on my windows machine?
Architecturally, if understood properly, the module plugs into stormproject, stormtask and stormticket. So making it part of stormproject might not make that much sense because it is independent of project.
Making it part of the core storm.module might make sense because it is ties all the modules together. However, I'm worried that if something is overlooked we disable the entire module, so keeping it independent has it's advantages, (I'll review the earlier issue queue for the module structure, maybe the current submodule structure is already in place by design.)
If putting into storm.module is the direction you would like to go, I would love to take a stab at it, but will most likely need more hand holding to get me through the process.
#26
That'd explain a lot!
Yes, the patch needs to be against the CVS checkout of Storm. There is a similar tool tortoise cvs that you can use if you're on Windows.
Take a look at http://drupal.org/node/253481/cvs-instructions/DRUPAL-6--1 for how to get the CVS checkout of Storm.
For thinking about which module to put it in, look at the dependencies between modules. There is a graphical representation of this in the documentation folder. The functionality should be placed at the lowest point where it is always required by the modules that need it. So perhaps into Storm project in this case?
#27
Activating thread for test bot (although predicting a 'patch will not apply' failure).
#28
The last submitted patch, stormmail.patch, failed testing.
#29
Hi Magnity,
You were right. It failed. I've got cvs up and running, I''ll try to create a patch to the storm module sometime next week.
Best regards,
Jonathan
#30
Hi Magnity,
The good news is is that I downloaded the latest dev through cvs and created the patch.
The bad news is, well it didn't work. I'm attaching it anyway maybe you'll have some pointers to get it work.
I still have to run it through coder.
I will give it a shot later next week.
Best regards,
Jonathan
#31
Setting to "needs review" so that testbot has a look...
#32
The last submitted patch, storm.module.patch, failed testing.
#33
Reroll (patch applied ok to my local checkout)
#34
Forgot to change status.
#35
Thanks a lot iamjon for getting this patch to us.
OK - the patch format thing seems to have only been related to some blank lines at the end of the file.
CNW for the following:
- Code style (especially indentation)
- Some bits still in Italian.
(maybe some more once these are fixed).
... and if it doesn't work, I guess that needs work too! I'll have a more detailed look at some point soon.
#36
+1
#37
OK, what's the status now? Here is my test.
I tried to patch storm.module with #33 but nothing happen, no "send mail to" in any of the ticket/task/project form.
Thanks guys.
#38
I made a simplified module based on the previous patches. Just unpack and enable it. We have been using it for a few days, so it might be buggy a bit, but if you put a report here i will try to fix it ASAP.
In the near future we will create a "daily reporting via e-mail" module, that will send the worker's timetrackings by e-mail for specified users. If you are interested about it, of course i can upload it here.
#39
Thanks parasite, I'll test it soon. I think your sub module sounds really interesting but you should talk with Magnity about what is the best strategy to release something like that. (If you look at comments #25 and #24, we agreed to include the changes within the scope of the current project, ie keeping it as a part of storm.module. You should open a new issue and discuss with Magnity what is the best way to continue. Any new functionality will be greatly appreciated I'm sure)
#40
- subscribing -
#41
Subscribing.
So, does anyone know if this will be integrated into the next release of Storm or not?
#42
Will be integrated when it is ready - this means:
Patch format rather than tar.gz.
Patch has been successfully reviewed for functionality and code style by a couple of storm users - and marked RTBC.
#43
+1
#44
- subscribing -
#45
+1
#46
- subscribing -
#47
Hi,
is this issue still under construction?
I added email notifications in the add on module Storm Contrib. If the module stormticket_assignment is activated there is the possibility to activate email notifications if a ticket or task is assigned to a person. Each person can set in his/her person settings if he / she wants to get the email notifications if a ticket/task is assigned to him/her. There is also the possibility to get emaul notifications if a task/ticket is modified.
There are also other email notifications like a nightly status mail for each project send to the project manager (can be set per project) or an email notification for persons who have not tracked enough time.
But there is still no notification if a project is modified. The question is when to send a notification. Only if the project is modified, or if the tasks and tickets are modified?
There are already notifications for modified tasks and tickets.
The documentation of Storm Contrib is not complete and i have to upgrade it. Storm Contrib is also still in development. IF desired you can also create an issue for Strom Contrib and i will add them. But i need some informations when a mail should be send. Maybe the current version of mail notifications is that what is desired.
For the future there is also the plan to create RSS Feeds as notifications for updates, so updates can also be read on readers.
#48
By adding token support, rules can be used to send emails (#332555: Token support- proof of concept).
#49
Another option is the module http://drupal.org/project/notifications_team
