Add a "SSH public key" field to the user profile

Sounds like a reasonable idea. Anyone who knows what this is will understand they're supposed to upload their public key, but just in case, we should probably call it "SSH public key" to be completely self-documenting and hopefully discourage people who don't know what they're doing from doing something really dumb. ;)

We should support multiple public keys. Users may have a personal and a work key. This is, also, how sites like github, unfuddle, bitbucket, and others work.

Darn we need a 'multiple textarea' profile field.

Or, we just add a single field for now and worry about N keys if/when it's actually a problem. ;)

If it's ok then I'll go ahead and add the field tonight.

Added the 'SSH public key' profile field on d.org.

For now I disabled the field from display on the user profile page, since it really messes it up.

Note that spammers love this new field...

It doesn't really help them since the links are "nofollow" but still it is annoying. We should have some basic validation for this field.

Is there any reason to worry about that field, when spammers can add spam links in other profile fields?

Considering that profile.module doesn't offer the possibility to assign a validation function to profile fields, and that it would be required to add custom code to drupalorg.module, is it worth doing it?

In the future we will need to use the content of that field for authentification, so IMO we should have clean content there.

just saw the issue, shouldn't the code for that field (including verification, maybe even a test against the blacklist from the debian ssl bug, etc) be in an extra module which is responsible for the git integration, instead of drupalorg.module?
Else the git module will depend on drupalorg.module, I don't think we want that...

If that profile field is used from a module, then I would think it makes more sense that the validation code is provided by that module, and not another one.
If the profile field would be implemented from the module that uses it, then that could be even better.

per #7 the field should've been disabled, but it isn't. Can any admin disable/remove the field for real now? We will have #720664: Create a "ssh_key" module, to allow upload of SSH keys to drupal.org user profiles for that.

It's currently set to 'Private field, content only available to privileged users.' so until we get the SSH keys module enabled, I don't see any reason to change it. We should give people a chance to copy over their SSH profile field to the new module if they want to.

well, given that the ssh key field is unvalidated and you don't need it for anything on d.o yet, I guess the number of users is really low. And the number of users which would not be okay with re-uploading their public key to d.o is even lower, so i'd just delete it now, so that no more people use that field and wait for the ssh_key module to arrive.
Do you think it makes sense to deploy ssh_key some time before the migration happens, as this profile field was added, or to deploy everything at once?

I agree with Dave Reid. There is no need to change that field, or to remove it until the module to handle SSH keys is deployed.

I am resetting the status of this issue.