Discuss this topic creator still shows as Anonymous

I guess some people don't care... The previous version of D6 was working because it would not use the full mechanism to generate a page. Now that I do that, it "breaks" since the Core detects the "wrong" user and reset the id to 0 (anonymous).

Thank you for reporting the problem though. 8-)
Alexis Wilke

Okay, I finally got a fix for this one. It is available in the -dev for now.

Thank you.
Alexis

Hi Alexis,
Has this fix been applied to Discuss This! 6.x-1.2 ?
I just installed that version and this problem is still there.
Let me know if you need more info or would like me to run some tests.

Cheers

Did it fail when you were an admin or an anonymous user?

Thank you.
Alexis Wilke

Here is how I was able to replicate:

1. Create a Story as an Admin User
2. Log in as Authenticated User with initiate discuss this topics permissions
3. Click on Discuss this link and post comment.

Comment shows correctly as posted by Authenticated User
Topic generated by Discuss This shows as posted by Anonymous.

Installed on D 6.15

Hmmm... I tested and it works on my site...

The user you assigned to the Post, does he have permission to create a forum post? That would be the one thing I could think of at this time...

Thank you.
Alexis

Yes, the user has the following permissions:
access discuss this links
initiate discuss this topics
create forum topics
delete own forum topics
edit own forum topics
access comments
post comments
post comments without approval

I have setup a new drupal install just to test this to avoid conflicts with other modules.

EDIT:
There are no errors showing in the report.
Drupal 6.15, Administration menu 6.x-1.5, Backup and Migrate 6.x-1.2, Contrib Toggle 6.x-1.3, Discuss This! 6.x-1.2, Token 6.x-1.12
No other modules installed.

Thank you Alexis,

Not ideal, but an easy workaround for this issue is to enter a user name into the Author of newly created Forum discussions: field in the Discuss This configuration.

Weka,

Ah! Yes! 8-)

I thought you had done that...

What non-workaround would you see fit?

It has been this way since the beginning of this module! So I did not think you did not change that field. Are you thinking we should have an option to make the Post author the same as the author of the page being discussed?

Thank you.
Alexis

8-)
I think it is fine the way it is, although making it default to the user who is starting the discussion may be better. I tried to use the [user-name] token, but that did not work.

The reason I did not change the field was because I thought that when left blank it will use the currently logged in user and that is how I interpreted the instructions below that field:

"Leave blank if you want the person who clicks the link to be the author of the new topic...."

I tested the [user-name] and [user-id] and they both worked for me... Hmmm...

I'm also looking into the blank entry.

The blank already meant the person who's logged-in.

I also added support to include the same author, the one who created the node (i.e. use * as the name.)

Thank you.
Alexis

Are you referring to the latest dev version or the 6.x-1.2. So far I only tested the 6.x-1.2. Just want to make sure.

I tested with the -dev... I'm not too sure whether it already was in 1.2, it is likely that the supposed blank support was.

This being said, there are issues with selecting an author for the post that is different from the author of the node being discussed. I noticed today that I did not implement the format support I meant to do a while back. I added that and noticed that forcing the format or using the default are okay ideas, but the result can be giving someone a better format than he/she normally has access to... The node Save actually fails at this time.

Anyway, there will be three possibilities:

1. Save with the same author as the author of the node being commented (*) — since that's the author of the node being commented, using the same format is safe
2. Save with the person posting the discussion as the author of the forum post (empty) — not safe since the current user may not have permission to use the format that the node being discussed used, and it is may not render properly either since some filters may not be applied as expected
3. Save with a specific author (author name) — not safe since that author may have the right to use a certain format, but the author of the node may have put bad code that now is (again) not formatted as expected and that could be dangerous

In other words, this module would have a security issues if I were to publish my current changes!

I think that what I need to do is apply all the filters at the time the module generates the forum post, then force the new format to the default format as I have been doing so far.

I guess, I'm talking to myself here since this is not directly linked with what you are asking for...

Anyway, yes, if you would please test with the -dev and report here whether you still have the problem, it would be great!

Thank you.
Alexis

Okay, I checked in some more code. But I would think that it is the same in regard to the user. Still, you may want to test the latest -dev version (which should be available within 12h) to make sure you are not reporting a problem that has now been fixed.

Thank you.
Alexis

Okay, that should be in 1.3.

Feel free to reopen the issue if you still have problems.

Thank you.
Alexis

In case anyone finds this: In my site, the Jammer module (which cleans up forms) hid the "author information" field and (at least for Forum Topics) caused the nodes to be authored by user 0 and shown as anonymous.

FormFilter module did not cause this error.

-Bram