Topic does not appear in the Forum

I tried putting a "dprint_r" of sub_form_state just before and a "print_r" of the "topic" object just after the drupal_execute on forum_node_form (line 659) and here is what i got:
BEFORE (note by the way that I actually configured the user id in Discuss This! admin - since i did not want it appearing as "Anonymous")

Array
(
    [values] => Array
        (
            [title] => autre enfant
            [body] => Following is a discussion on the Book page item titled: <a href="/drupal-test/en/node/62">autre enfant</a>.<br/>Below is the discussion so far. Feel free to add your own comments!<br/>
            [format] => 
            [name] => 512004-DGI
            [taxonomy] => Array
                (
                    [6] => Array
                        (
                            [20] => 20
                        )

                )

            [log] => Node automatically created by discussthis for comment with dprint
            [op] => Save
            [status] => 1
        )

    [discussthis] => Array
        (
            [post] => 1
        )

)

AFTER

stdClass Object ( [type] => forum [uid] => 1 [body] => [title] => [format] => [status] => 1 [promote] => [sticky] => [created] => 1258722183 [revision] => [book] => Array ( [original_bid] => 0 [menu_name] => [nid] => new [bid] => 0 [router_path] => node/% [plid] => 0 [mlid] => 0 [has_children] => 0 [weight] => 0 [module] => book [options] => Array ( ) [parent_depth_limit] => 8 ) [comment] => 2 [menu] => Array ( [link_title] => [mlid] => 0 [plid] => 0 [menu_name] => navigation [weight] => 0 [options] => Array ( ) [module] => menu [expanded] => 0 [hidden] => 0 [has_children] => 0 [customized] => 0 [parent_depth_limit] => 8 ) [taxonomy] => Array ( [] => stdClass Object ( [vid] => 6 [tid] => ) ) [nid] => 61 ) 

Don't know if this helps. The Forum tid is indeed 20 by the way, so it looks as if that is getting uncovered correctly which was my first thought

I look forward to a fixed version - this is a really cool module and I very much hope to be able to use it soon! If I can help with more testing let me know.

Here is a hack which is not very nice but which seems to do the trick. I noticed that in discussthis_nodeapi the "insert" operation did not do anything and just drops through to the update (is this intentional?).
So I tried doing this:

  case 'insert': // create or update/move forum topic
  global $user;
    if ($node->type == 'forum') {
        if (!$node->tid) {
          $node->tid = end(end($node->taxonomy));
        }
        if ($node->uid == 0 && $user->uid != 0) {
          $node->uid = $user->uid;
        }
    }
    break;

Not very elegant I know but it does seem to work. At least, the bit to set the tid seems to work - however the bit of code to set the node uid to the user uid still fails to get the forum topic to appear as anything other than "Anonymous".
Another oddity is that when I create a new Story and set the "Discussthis" forum to something other than the default, it doesn't "take" - you have to go back and modify it again to get that to work.

Actually of course I realise that the correction of the user id bug can't be done here, precisely because you only get into discussthis_nodeapi AFTER the node has been created (with the wrong user id). So here is a tidier version of the code which seems to fix the bug of not loading the initial post in the forum (in discussthis_nodeapi):

  case 'insert': // create or update/move forum topic
      if ($node->type == 'forum' && !$node->tid) {
          $node->tid = end(end($node->taxonomy));
      }
      break;

I think this should work under all circumstances because logically a forum post can only belong to one term. Unless of course you allocate a second vocabulary to forum entries - so perhaps you should get the forum vid variable first and make sure that you check that one only. Maybe I'll try that later to make it a bit more robust.

I should have seen that!
Actually (if you have not already done so), I think you could replace this:

    if ($vocabulary->tag) {
    // tags are a special case, also you probably cannot choose tags for a forum...
        $sub_form_state['values']['taxonomy']['tags'][$vid] = taxonomy_implode_tags($terms, $forum_vid);
    }
    else {
        $sub_form_state['values']['taxonomy'][$forum_vid] = $tid;
    }

with just this:

    $sub_form_state['values']['taxonomy'][$forum_vid] = $tid;

I've noticed that when you create a forum for the first time Drupal automatically creates a vocabulary (set in the 'forum_nav_vocabulary' variable) with enforced single terms, so it is not possible to have tags. This is logical if you think about it. There is only ONE vocabulary allowed which defines the forum structure, and it is necessarily a single-term vocabulary because otherwise you could have the same post in multiple forums which would not really make sense.