Download & Extend

Remove img "align" attribute

Project:ImageField Assist
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:lourenzo
Status:closed (cannot reproduce)

Issue Summary

"Align" attribute is deprecated since HTML 4.02. I found some bugs caused by the use of this property in IE7. As default Drupal themes (and the mostly used themes, I think) are XHTML strict, and as IFA already uses classes with css "float" properties, I think that this attribute can be safetly removed.

AttachmentSize
ifa_img_no_align_attribute.patch713 bytes

Comments

#1

Here is the patch for the most recent release of IFA.

AttachmentSize
ifa_remove_align.patch 869 bytes

#2

Fixed on dev.
Thanks

#3

Status:active» fixed

#4

Status:fixed» needs review

When using tinyMCE, the image tag still have this attribute.
Although, the tinyMCE document leaves in an iframe, and uses another DOCTYPE,

Can this difference between wysiwyg cause formatting result issues?

#5

tinyMCE uses this attribute only in it's interface or it's saved at the end result?

I found a issue only in IE7 at a specific situation, when a image has this attribute AND a float declaration.

#6

Assigned to:Anonymous» lourenzo
Status:needs review» closed (cannot reproduce)

Couldn't reproduce on recent releases.