Fixes and improvements to emthumb

I don't think it's quite working.

My source file is named jj.jpg
I specified the Image path setting for the Embedded Custom Thumbnail section of the CCK field to thumbs.

After I press the upload button, my file appears in files/thumbs/jj.jpg and it's thumbnail is displayed.

After I submit my node, I edit it and my thumbnail is no longer displayed.

I looked in the database table files and the entry is files/thumbs/jj.jpg seems correct.

I looked in the database table for my content type and found my entry. For the field_embedded_video_url_data column of my entry:

"emthumb";a:2:{s:11:"emthumb_alt";s:6:"jj.jpg";s:13:"emthumb_title";s:6:"jj.jpg";}

I think the module isn't putting the path together correctly.

If I try the procedure of #601466: Thumbnails doesn't work CUSTOM THUMBS NOT OVERWRITING DEFAULT (submit without hitting upload), my CCK entry gets a better value for the thumbnail and when I edit the node, I can see my thumbnail.

"emthumb_alt";s:6:"jj.jpg";s:13:"emthumb_title";s:6:"jj.jpg";
s:8:"filename";s:6:"jj.jpg";s:8:"filepath";s:32:"sites/wwcdev/files/thumbs/jj.jpg";
s:8:"filemime";s:10:"image/jpeg";s:8:"filesize";i:345692;s:3:"fid";s:2:"15";}

Yes, I applied patch correctly.

The key is the upload button. If you hit it, emthumb will be broken. But, if you browse to the file and submit, everything is OK.

I used CSS to hide the button for now.

I tested this out and it still needs some work. First of all, I couldn't get the emthumb form to show at all unless I changed the first two arguments (removed the reference) of emthumb_emfield_widget_extra():

i.e.

function emthumb_emfield_widget_extra(&$form, &$form_state, $field, $items, $delta = 0, $module) 

changed to

function emthumb_emfield_widget_extra($form, $form_state, $field, $items, $delta = 0, $module) 

However, even after I made that change the module still isn't working. At the moment here's what happens. I can upload an image and it shows up on the node edit form as expected. But- if I save the node the old stored thumbnail remains, even though the custom thumbnail is in fact uploaded to the correct folder. I don't have time to look into this further, but I think this is close.

Thanks for your work on this!

I can confirm that Aaron's workaround from here works:
#601466: Thumbnails doesn't work CUSTOM THUMBS NOT OVERWRITING DEFAULT
That is to say, if I click "save" after selecting the file it works as expected. But, if I click 'upload' and then 'save' it doesn't work.

Can you check and make sure that the patch above reflects the last changes you made to the module. I can tell you 100% that this is not working atm, even though it applies cleanly against the latest development snapshot.

If you let me know what you want a backtrace of, I'm happy to provide it.

I tried the patch as well and have the same issue in which uploaded images are not saved.

They are placed in the file system. In the emthumb_widget_element_process function the new image information is placed into the $elements variable which the function returns but are lost upon clicking submit or preview. I ran out of time on this but did notice that the 'insert' case in emthumb_emfield_field_extra is empty. Could be a culprit.

I just ran the patch, ran cron and flushed the cache 3 times and the custom thumbnail stayed! Nice Job. I will keep monitoring the situation and if anything changes I will report it.

This works on my 6.14 site after this patch is applied from the thread you identified above: http://drupal.org/node/591696#comment-2097466

OK- I went ahead and committed this patch. I'm marking this as "Postponed" for now until the core issue is fixed.

Great job. I can confirm the new patch against the latest dev is working. Thanks so much for finally rectifying this mess.

committed the fix. thanks for the work, andrew!

Hello,

the Patch "fix_emthumb.patch" dont works!

I use emfield-6.x-1.18. - for patching i use "Cygwin"! Only errors ...

Hunk #1 Failed at 1
Hunk #2 Failed at 12
Hunk #3 Failed at 39
.... and so on

It is not possible to Patch this Version!

The thumbnails from embimage generated wrong - the size is not minimzied - the thumbnails have all the full-original-size!

I tested "Development releases" from emfield - same Problem!

Last 2 days i try hard to break this problem - it is not possible!

I need the Thumbnails for my Views-Block - it is absolutly important but i go mad!

Thumbnails from embvideo are running but not from embimage!

What i make wrong - i am so frustrated?

Sorry for my bad english!

patch is against the latest 6.x-1.x-dev

Latest Version dont work correct!

Latest Version make "Preview-Images" in "files Drupal-directory" but no "thumbnails" .... All settings are correct! My thumbnails-settings are 100 px - "Preview-Image-Setting" -> 240px ....

Preview-Images are ok but Thumbnails are not applied!

Hello,

here is a second problem!

When i make the settings for "Preview-Images" only 100 px width and this images i take for "Thumbnail alternate" (the real thumbnails are not applied) then emfield save this images in files-directory! (files/emimage-custom_url-http:--.......jpg) Thats ok!

Now i will make a block with Views - block must show 10 of local Preview-Images ( one image (Image1) from 10 Nodes).

In Views/Block i set: Field -> Content -> Image1 - the format from "Image1" i set to "Preview Size Image" - i save

When i call the block in Node - Views show me the 10 images but all Image-Urls are from external !

<img src="http://www.external-URL.com/images/5662.jpg" alt="" title="" width="100" height="180" class="custom_url" />

The width and high is correct (assumed from "Preview-Setting") but the Image URL is wrong!

Image-URL must be <img src="sites/default/files/emimage-custom_5662.jpg" alt="" title="" width="100" height="180" class="custom_url" /> (there are the local Previw-Images)

Is the Module full of bugs or i am dimwitted???

Or has anyone an other idea?

I am desperate!

(Sorry for my bad english)