drush_log() should write to stderr, not stdout, and $green should actually be green.

I'll let adrian chime in here. Meanwhile, an equivalent way to log errors that is more clear is drush_set_error('foo')

FYI, nothing goes to stdout except errors unless you have an elevated debug level. are you running with --verbose (-v) or --debug (-d)?

I did mean drush_set_error

comments?

I agree that stderr should be preferred to stdout for all log, error and debug messages.

I agree everything should go to stderr, but if things are going to stdout now (which i find odd), Aegir will need some patching.

I think this change should be done before 3.0 gets shipped.

I need this too..

How should this be implemented? Should we output exactly the same format? It's not very parsable, but perhaps that doesn't matter?

for now, I just chucked this in my drush_log

if ($error || $type == 'failed') {
    // write to stderr
    fwrite(STDERR, "$type: $message \n");
    return;
  }

But obviously, we should do better.

Best,
J

+1 for dumping errors into stderr. What's the problem with in implementing this?

No problem. Someone needs to contribute a patch.

Yeah, I've got this working; I'll post a patch later.

Switching drush_log to stderr required only a couple trivial changes. As an added bonus, this patch also fixes a typo in $green. Previously, $green rendered as yellow. Adjusted per http://rtfm.etla.org/xterm/ctlseq.html; "32: Set foreground color to Green", "33 Set foreground color to Yellow".

Looks good to me. Could we add some docs about how to use this. Maybe a script in examples? Otherwise, a link to STDERR usage somewhere on the internets.

I'd love some +1 from the Aegir folks.

Looks good to me too - basically we just want drush_print output (i.e. content, not log output) to go to stdout by default, which I think is what this does. I agree $handle usage could use some docs.

I did a couple more tests to convince myself that the output and data structures in backend invoke were not affected, and as I had presumed, it came out unchanged. Committed with an additional comment for $handle in drush_print.