Updating the UI text for the modules listing page. Re: updates availability.

I can't seem to attach images.

Hmm.. let me save and retry.

CommentFileSizeAuthor
#16 cleanup.errormessages_0.patch3.82 KBdawehner
#14 cleanup.errormessages_0.patch4.06 KBdawehner
#11 cleanup.errormessages.patch2.16 KBAnonymous (not verified)
#9 cleanup.errormessages.patch2.2 KBBojhan
#2 update-check2.patch1.13 KBheather
update-check1.patch1.13 KBheather
update-fixed.png10.49 KBheather
update-before.png24.05 KBheather

Comments

heather’s picture

heather commented

Changed from:

To:

heather’s picture

heather commented
StatusFileSize
new update-check2.patch1.13 KB

Oh! no!

Don't choke, testbot: check this one..

(fixed to include amendment to update.test)

Bojhan’s picture

Bojhan commented

The goal is to eliminate the large ammount of text in these messages, so people actually read them.

Some examples of other text to tackle :

Current
"There was a problem determining the status of available updates for one or more of your modules or themes. See the available updates page for more information and to install your missing updates."

Proposed
"There was a Problem checking [available updates] for your modules or themes."

Current
"There was a problem determining the status of available updates for your version of Drupal. See the available updates page for more information and to install your missing updates."

Proposed
"There was a problem checking [available updates] for Drupal."

Current
"One or more problems were detected with your Drupal installation. Check the status report for more information."

Proposed
Detected problems with your installation, check the [status report].

Bojhan’s picture

Bojhan commented
Status: Needs work » Needs review

--

Title: Update status ui-text » Update error messages
Priority: Normal » Critical
Status: Needs review » Needs work

The last submitted patch failed testing.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Needs work

Yup, less is more. ;) All look good to me, except this one:

Current
"One or more problems were detected with your Drupal installation. Check the status report for more information."

Proposed
Detected problems with your installation, check the [status report].

That's actually from system module (system.admin.inc to be precise) and appears on a lot more pages, etc. That part should probably be handled in a separate issue/patch, since it's unrelated to update.module.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Component: update.module » user interface text

Why can't we change the component to "user interface text" and address the #6 and similar issue here.

Status: Needs work » Needs review

Bojhan requested that failed test be re-tested.

Bojhan’s picture

Bojhan commented
StatusFileSize
new cleanup.errormessages.patch2.2 KB

Ok, I did the other messages. Except the one dww pointed out should be done in another patch.

Status: Needs review » Needs work

The last submitted patch failed testing.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
StatusFileSize
new cleanup.errormessages.patch2.16 KB

no changes, just fixed the line endings after a chat with Bojhan in #drupal.

Status: Needs review » Needs work

The last submitted patch failed testing.

Bojhan’s picture

Bojhan commented
Status: Needs work » Needs review

Can anyone write the updated tests? I dont know how to.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new cleanup.errormessages_0.patch4.06 KB

Here is a fast patch. I'm running currently local the tests, but they need a lot of time, so uploading the patch in the meantime :)

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

sadly its not working

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new cleanup.errormessages_0.patch3.82 KB

So... this should work

dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community

#16 looks great to me. Sorry for the brittle update.module tests...

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

David_Rothstein’s picture

David_Rothstein commented
Issue summary: View changes
Related issues: +#2545520: The same link "available updates" links to two different pages in the same paragraph when there is a problem checking available updates

Current
"There was a problem determining the status of available updates for your version of Drupal. See the available updates page for more information and to install your missing updates."

Proposed
"There was a problem checking [available updates] for Drupal."

That proposal does not seem to be what the patch actually resulted in. The first sentence was changed, but the second sentence was left in place. Being discussed further in the linked issue.