I would like to do something about this.

CommentFileSizeAuthor
#1 slideshare-639514-1.patch1.08 KBsfyn
#6 slideshare-639514-6.patch1.49 KBsfyn

Comments

sfyn’s picture

sfyn commented
StatusFileSize
new slideshare-639514-1.patch1.08 KB

UPDATE: Use the patch in comment #6 instead
Here's a fairly hacky patch for this feature. Needs a lot of work to make sense.

ademarco’s picture

ademarco commented
Status: Active » Fixed

Patch applied and committed to HEAD. Thanks for patching.

sfyn’s picture

sfyn commented
Status: Fixed » Needs work

Update

This patch only works on fields where slideshare is the only enabled source for embedded content. Otherwise, it overrides url handling for other content sources.

ademarco’s picture

ademarco commented

True, just noticed right now. Thanks for reporting.

sfyn’s picture

sfyn commented

Update number two

I rolled back to my old copy of slideshare.inc, and it seems like this is was already a slideshare bug pre-patch. I am trying to work out what is going on.

sfyn’s picture

sfyn commented
StatusFileSize
new slideshare-639514-6.patch1.49 KB

Here's a new patch - I discovered regex errors related to using the pipe as a delimiter. Changing the function to return NULL now has slideshare peacefully co-existing with other providers. Note that this is patched against the current dev release and does NOT take into account the latest cvs commits.

sfyn’s picture

sfyn commented
Status: Needs work » Needs review

Patch committed to HEAD

ademarco’s picture

ademarco commented
Status: Needs review » Fixed

Working well for me.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.