I'm not sure I understand the benefit of having certain pages that you are able to turn off the external functionality, however I can see the benefit of being able to turn it off for certain domains or urls in the links themselves. What are your thoughts on adding that to this module? I could work on a patch if you are interested.

Thanks!

CommentFileSizeAuthor
#10 639854-add_ignore_by_url_pattern-10.patch2.88 KBlunazoid
#9 639854-add_ignore_by_url_pattern-9.patch2.88 KBlunazoid
#6 patch_add_ignore_by_url_pattern.diff2.53 KBsctteea

Comments

mcrittenden’s picture

mcrittenden commented
Title: Exclude urls not pages » Option to exclude URLs not pages
Status: Active » Needs work

Good idea. I'd still like to leave the option to exclude certain pages but excluding URLs would be another good option.

So yes, happily accepting patches.

mcrittenden’s picture

mcrittenden commented
Title: Option to exclude URLs not pages » Option to exclude URLs

Oops.

mcrittenden’s picture

mcrittenden commented
Status: Needs work » Active

No patch yet.

q0rban’s picture

q0rban commented

Whoops, forgot to subscribe to the issue queue. :D

q0rban’s picture

q0rban commented
Status: Active » Postponed

I don't really remember why I wanted this so I'm not going to write a patch for it, seeing as how I'm obviously living fine without it. ;)

sctteea’s picture

sctteea commented
Version: 6.x-1.5 » 7.x-1.x-dev
Status: Postponed » Patch (to be ported)
StatusFileSize
new patch_add_ignore_by_url_pattern.diff2.53 KB

I created a patch to implement this in the 7.x.1.x branch.

I found that the module can interfere with other modules when certain links are processed. Example: TranslateThis module
It uses a regular expression test to ignore links for given patterns.

likewhoa’s picture

likewhoa commented
Status: Patch (to be ported) » Needs review

need some testing...

lunazoid’s picture

lunazoid commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I know it's been a few years, but the patch in #6 still applies fine to the latest dev, and works as expected.

lunazoid’s picture

lunazoid commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 639854-add_ignore_by_url_pattern-9.patch2.88 KB

I just encountered a problem where a link that was in the ignore list was still getting the "external-processed" class added. This patch seems to fix that for us, but I'm sure it could be optimized.

lunazoid’s picture

lunazoid commented
StatusFileSize
new 639854-add_ignore_by_url_pattern-10.patch2.88 KB

Disregard my patch in #9, I must have been half asleep. While it worked locally, it didn't work on our hosting server. This version does a much better job.

lunazoid’s picture

lunazoid commented
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs review » Needs work

Still a useful idea for 8.x Please use a MR if anyone is still interested to implement this.