Hi,

This is a 2 part bug I think. Issue one is the one in the description - if you have 'No notifications' selected you still see the option to receive a notification when you post a comment. It isn't selected by default, but users can select it and submit the comment.

This may be by design, but the second issue is that no matter what the user selects they don't receive notifications. I believe this is due to $form ['notify_type'][#default_value'] = $preference being set to , which in the case of 'No notifications' is 0.

So the behaviour is that 'No notifications' in /user over-rides the node-specific selections, which is unclear. I think that if this is the desired behaviour then my patch will work - it checks $preference and hides the checkbox if it's 0.

Of course if the node-specific option is supposed to take precedence then my patch isn't much help except as a band-aid.

Thanks

Comments

greggles’s picture

Status: Active » Needs work

This code has changed a bit recently - can you upgrade to 6.x-1.3 and try again?

It is by design that the box shows regardless of the preference. People should be able to set it to not-subscribed by default and then still subscribe on an individual comment basis.

serenecloud’s picture

Hi greggles,

I've managed to get around to upgrading to 6.x-1.3 and the module now behaves as I expected. Your selection overrides your User Profile settings.

I'm not sure what should happen to this bug - it's a valid 1.2 issue, but I'm sure most can upgrade to 1.3

greggles’s picture

Status: Needs work » Closed (duplicate)

Yes, the expectation is that people will just upgrade to the 6.x-1.3 version. We can already see that happening - http://drupal.org/project/usage/comment_notify - 1/4 of the users are up to the 6.x-1.3 version.