binford2k [binford2k]

We review only a theme / module per application. Choose the one you want to be reviewed, and let us know it.

You mean I have to have each project approved?

No. I meant that we don't review more than one theme/module per application; a CVS application is made just once.

      $form['reminders']['reminders_roles'] = array(
        '#type' => 'checkboxes',
        '#title' => 'Send reminders to',
        '#default_value' => _reminders_node_get_roles($node-nid),
        '#options' => user_roles(TRUE),
      );
      // interval is in minutes, you can add more intervals by converting to minutes and adding them to #options
      $form['reminders']['reminders_interval'] = array(
        '#type' => 'select',
        '#title' => 'Send reminders',
        '#default_value' => _reminders_node_get_interval($node->nid),
        '#options' => array(
            '60' => t('hourly'), 
            '1440' => t('daily'), 
            '10080' => t('weekly'), 
            '40320' => t('monthly'), 
            '524160' => t('yearly')
        ),

Strings used in the user interface needs to be translated; this includes also the strings used as options for the form fields.

function _reminders_node_get_interval($nid) {
  $result = db_query('SELECT send_interval FROM {reminders} where nid = %d', $nid);
  if($row = db_fetch_array($result))
    return $row['send_interval'];
  else
    return 1440; // minutes in a day
}

The code could use db_result().

  if(in_array(2, $roles)) {
    // get all authenticated users
    $result = db_query('SELECT u.uid FROM {users} u
	                 WHERE u.uid NOT IN (SELECT uid FROM {reminder_logs} WHERE nid = %d)
                   OR TIMESTAMPDIFF(MINUTE, (SELECT MAX(ts) FROM reminder_logs WHERE uid = u.uid), NOW()) >= %d',
                   $nid, $interval);
  }
  else {
    $roles = implode(',', $roles);     
    $result = db_query('SELECT u.uid FROM {users} u
	           INNER JOIN {users_roles} r ON u.uid = r.uid WHERE r.rid IN (%s)
	           AND (u.uid NOT IN (SELECT uid FROM {reminder_logs} WHERE nid = %d))
	           OR TIMESTAMPDIFF(MINUTE, (SELECT MAX(ts) FROM {reminder_logs} WHERE uid = u.uid), NOW()) >= %d',
	           $roles, $nid, $interval);
  }

The first query is specific for a database engine; both the queries have securities issues as they don't filter the returned users in the right way.

There have not been replies from the OP in the past 7 days. I am marking this report as won't fix.