Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Nov 2009 at 16:37 UTC
Updated:
11 May 2010 at 10:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
jhodgdonYeah, that function header is not very useful at all.
http://api.drupal.org/api/function/_book_toc_recurse/7
Should also be backported to Drupal 6 after it is fixed.
Comment #2
jhodgdonSeems like a good novice project
Comment #3
jhodgdonWhoops, selected wrong tag
Comment #4
fureigh commentedI looked at this but it seems like it makes more sense to document all of the arguments in that function if documenting $exclude and $mlid... removing the novice tag for now. (Maybe I'll try again when it's not so late at night!)
Comment #5
caligan commentedComment #6
jhodgdonNice doc writing!
Formatting has some problems:
- spaces at ends of some lines
- final */ needs to be on its own line
- return value not documented - is there one? If not, mention in @param blocks that the particular parameter is modified in place
- wrap as close to 80 characters as possible without going over
- we don't put & in the @param line (it's in the function signature only)
- 2nd line would be better s "Reference to the table of contents array.", I think? Saying $toc is a reference to $toc is not very useful. :)
Comment #7
caligan commentedGot it, thanks - I think this fixes everything you mention. :)
Comment #8
jhodgdonYou need to not split words with hyphens. This documentation will be formatted differently when it's displayed on api.drupal.org, and that will cause it to appear as "incre- mented". Please just move that whole word to the next line.
Also, in this section:
several more words could go up onto the first line, to try to wrap at as close to 80 characters as possible.
Other that those two spots, looks great, thanks!
Comment #9
caligan commentedAh, I see. Gotcha! (And I don't know how I overlooked the too-short line. I re-checked several times, darn it.) Also tweaked wording a tiny bit for decreased redundancy.
Comment #10
jhodgdonGreat!
Comment #11
dries commentedThanks for your work, Caligan. Committed to CVS HEAD.