Feed attached to Block with Attachment displays twice [#640862]

Not sure if it's a bug, but it certainly is curious.

I have three displays:
- Block
- Attachment
- Feed

If I attach the Feed to the Block, all is well-- the Feed icon displays in the Block. But if I also attach the Attachment to the Block, the Feed displays twice. It is as if, by attaching the Attachment to the Block, it inherits the Feed.

Is there some logic, here, that I'm just not getting? If not, is there a fix?

Thanks!

Comment	File	Size	Author
#3	views-640862.patch	1022 bytes	dawehner
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

merlinofchaos CreditAttribution: merlinofchaos commented 23 November 2009 at 20:59

Hm. I think the rendered feed_icon isn't getting cleared when the view is cloned. In view.inc in the function clone_view() try adding 'feed_icon' to the $keys array and see if that fixes the problem?

Comment #2

Ellen Dee CreditAttribution: Ellen Dee commented 23 November 2009 at 21:56

That did it. Thanks!

Comment #3

dawehner

German

CreditAttribution: dawehner commented 9 January 2010 at 15:02

Status:

Active

» Needs review

File	Size
views-640862.patch	1022 bytes

Perhaps there should be a way for plugins to extend this array.

This patch just fixes this problem.

Comment #4

merlinofchaos CreditAttribution: merlinofchaos commented 12 March 2010 at 00:17

Status:

Needs review

» Fixed

Well, the root problem is that there is too much runtime data on the view object. Something I would like to do someday is add a view_instance object that stores runtime data, so the $view itself could be clean. Then cloning a view gets a lot simpler. Plus, you could have several instance objects on a view, if done right.

This fix is committed to all branches.