Not sure if it's a bug, but it certainly is curious.

I have three displays:
- Block
- Attachment
- Feed

If I attach the Feed to the Block, all is well-- the Feed icon displays in the Block. But if I also attach the Attachment to the Block, the Feed displays twice. It is as if, by attaching the Attachment to the Block, it inherits the Feed.

Is there some logic, here, that I'm just not getting? If not, is there a fix?

Thanks!

CommentFileSizeAuthor
#3 views-640862.patch1022 bytesdawehner

Comments

merlinofchaos’s picture

merlinofchaos commented

Hm. I think the rendered feed_icon isn't getting cleared when the view is cloned. In view.inc in the function clone_view() try adding 'feed_icon' to the $keys array and see if that fixes the problem?

Ellen Dee’s picture

Ellen Dee commented

That did it. Thanks!

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new views-640862.patch1022 bytes

Perhaps there should be a way for plugins to extend this array.

This patch just fixes this problem.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Well, the root problem is that there is too much runtime data on the view object. Something I would like to do someday is add a view_instance object that stores runtime data, so the $view itself could be clean. Then cloning a view gets a lot simpler. Plus, you could have several instance objects on a view, if done right.

This fix is committed to all branches.

Status: Fixed » Closed (fixed)
Issue tags: -views feed attachment display

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +views feed attachment display

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.