Image style names are supposed to be unique, but this is not reflected in the database schema.

CommentFileSizeAuthor
#6 image_update_path.patch525 bytesmr.baileys
image-style-unique-1.patch940 bytesc960657

Comments

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented

Yes, they should be unique. The interface already imposes this restraint through validation, so I agree it makes sense to do the same in the database.

Reviewed, applied, tested, RTBC.

c960657’s picture

c960657 commented
Issue tags: -quickfix +Quick fix
mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Status: Needs review » Reviewed & tested by the community

Strange, I though this was set to RTBC in #1...

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Priority: Normal » Critical
Status: Fixed » Needs work

Warning: this modification was not made in the upgrade path. image_update_7000() still sets a plain index, not a unique index.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Status: Needs work » Needs review
Issue tags: -Quick fix
StatusFileSize
new image_update_path.patch525 bytes

Sorry, didn't occur to me that the upgrade path needed updating too. Patch attached.

recidive’s picture

recidive commented
Status: Needs review » Reviewed & tested by the community

The patch fixes the upgrade path as advised.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.